-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corrupted fonts in Firefox #37
Conversation
Hi! Thank you for this PR! Doubly thanks for following the git commit message standards. Can you summarize/explain in the first commit (via |
This basically makes `Twitter Color Emoji` a preferable serif, sans-serif and monospace font with fallback to corresponding variants of `DejaVu *` for non-emoji characters. This way we don't need to use `Bitstream Vera` and can still have all of colored emoji characters.
Bitstream Vera is not used/needed anymore, so readme, tests and configs were adjusted accordingly.
Added explanation to commit message, hopefully it is enough |
Sorry. This doesn't work. It will re-open these cans of worms: 13rac1/emojione-color-font#25 and 13rac1/emojione-color-font#16 Looks like VLC is fixed though: 13rac1/emojione-color-font#5 More details into the hours/days of research I've done. Your branch
Current V1.3 config
I've actually tried the fix described in #19 too, since your change is so close. The difference is: |
Interesting, I'd say this is a bug in mentioned programs, but, obviously, they are out there and it is not fair to expect all of them to be fixed any time soon. I think in this case it would be better not to offer any default config at all, but instead suggest a couple of typical configs like current default and one that is provided in this repository for people to choose from. Otherwise some apps will be broken. P.S. Genuinely disappointed by the state of fonts system in Linux 😢 |
True, but one of those is Chrome
The problem is if I do that I will get piles of questions about why this doesn't work. The vast majority of users do not care about custom fonts and just want to see the emoji characters work. I am not building this for power users and, in fact, much of my original goal doing the projects in the first place is complete. Since I am sun-setting the emojione-color-font project shortly, it'll be less hassle. Hmm.. Perhaps I could make a separate no-config deb?
What's funny is Linux fonts are so much more configurable than Mac/Windows. The only problem is this glyph selection issue. Both Mac/Windows workaround it by not having emoji characters in their default fonts. |
Technically, it doesn't work properly either way, so you're in somewhat awkward position here and now I understand that you've chosen the approach that causes less harm.
This will work for me, it is so much easier to add something that override. I think even better would be to have
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE fontconfig SYSTEM "fonts.dtd">
<fontconfig>
<!-- Add emoji generic family -->
<alias binding="strong">
<family>emoji</family>
<default><family>Twitter Color Emoji</family></default>
</alias>
<!-- Alias requests for the other emoji fonts -->
<alias binding="strong">
<family>Apple Color Emoji</family>
<prefer><family>Twitter Color Emoji</family></prefer>
<default><family>sans-serif</family></default>
</alias>
<alias binding="strong">
<family>Segoe UI Emoji</family>
<prefer><family>Twitter Color Emoji</family></prefer>
<default><family>sans-serif</family></default>
</alias>
<alias binding="strong">
<family>Noto Color Emoji</family>
<prefer><family>Twitter Color Emoji</family></prefer>
<default><family>sans-serif</family></default>
</alias>
</fontconfig>
Looks like a toolkit issue and some are simply not as advanced as the others.
Do you think it is viable to make the same happening for Linux? Maybe you're aware of open issues somewhere? |
13rac1/emojione-color-font#17 (comment) Is where I first documented the idea. I haven't heard of it elsewhere.
|
This may be relevant too: 13rac1/emojione-color-font#40 |
Fixes #21