-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Support [breaking change Ctor API] #107
CMake Support [breaking change Ctor API] #107
Conversation
Memory usage change @ 28f719d
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define MilliSecondFunc
, use instead of MicroSecondFunc
.
Memory usage change @ 577a29d
Click for full report table
Click for full report CSV
|
I suggest that you add |
@aentinger I have made that change. This does end up modifying the constructor, are we not concerned about this breaking change? |
You could mitigate it with an default argument, although on second check you can't. Well, I'm okay with a breaking change now and then. This one is allright. |
You'll need to fix the breaking changes in the examples though ... |
This pull request introduces CMake support to the project. This enables use of the library outside of the Arduino ecosystem, just as with the cyphal library. This would be beneficial to many who want to make use of the robustness of 107 systems work, but that operate in frameworks other than Arduino.