add SequenceIndexerOpts #528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
approved these changes
Jul 15, 2024
Comment on lines
+36
to
+38
| const [projectAccessKey, jwtAuth] = args | ||
| this.projectAccessKey = projectAccessKey || undefined | ||
| this.jwtAuth = jwtAuth || undefined |
There was a problem hiding this comment.
this is for backward-compatibility?
can we console.error() with a warning to update to the new Opts object?
was this implemented a long time ago? do you expect customers using it?
| constructor( | ||
| hostname: string, | ||
| projectAccessKey?: string, | ||
| jwtAuth?: string |
There was a problem hiding this comment.
I think this is fine
I'm just thinking - should we call it SecretKey as in the Builder UI? cc @moskalyk
There was a problem hiding this comment.
https://github.com/0xsequence/issue-tracker/issues/4425
Let's revisit. Do we have this pattern in any other sequence client?
| export class SequenceIndexer extends IndexerRpc { | ||
| public jwtAuth?: string |
There was a problem hiding this comment.
I guess we should call it apiSecretKey, as this is called "Builder Admin API Secret Keys" in the Builder UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
SequenceIndexerOpts, this type can be used to configure different authentication keys without relying on positional arguments. This is backwards compatible with the current positional-arguments based configuration.Reference: https://github.com/0xsequence/issue-tracker/issues/2358