Use package reference instead of project reference#2
Closed
virzak wants to merge 1 commit into0xced:mainfrom
Closed
Use package reference instead of project reference#2virzak wants to merge 1 commit into0xced:mainfrom
virzak wants to merge 1 commit into0xced:mainfrom
Conversation
Owner
|
Hey Viktor, sorry I completely forgot about this pull request! Note that I have now released Chisel. Getting rid of the Azure authentication libraries from Microsoft.Data.SqlClient is now really easy. And transitive dependencies are properly handled! <ItemGroup>
<ChiselPackage Include="Azure.Identity" />
<ChiselPackage Include="Microsoft.IdentityModel.JsonWebTokens" />
<ChiselPackage Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Chisel" Version="1.1.2" PrivateAssets="all" />
<PackageReference Include="Microsoft.Data.SqlClient" Version="6.0.2" />
</ItemGroup>I also updated the README in this repository to mention Chisel. And thanks to the combination of dotnet/SqlClient#2577 and dotnet/SqlClient#2636, getting rid of |
Author
|
No worries at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires less effort for the user since they can simply reference a nuget package.
If you like the approach we can remove the
nuget.configfile and use nuget instead of myget.