Skip to content

Conversation

@5eeman
Copy link
Contributor

@5eeman 5eeman commented Oct 28, 2025

No description provided.

@5eeman 5eeman requested review from Copilot and plusema86 October 28, 2025 12:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates package dependencies and migrates away from the encrypt package to a custom symmetric encryption implementation. The main changes modernize the SDK's dependencies and reduce reliance on third-party encryption libraries.

Key changes:

  • Replaced encrypt package with custom SymmetricKey/AesCipher implementation
  • Removed bip32 package in favor of minimal custom BIP32 derivation code
  • Updated pointycastle from ^3.7.0 to ^4.0.0 and various other dependency version bumps

Reviewed Changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pubspec.yaml Updated SDK dependencies including pointycastle upgrade and removal of encrypt/bip32 packages
lib/common/crypto/symmetric.dart New custom AES encryption implementation replacing encrypt package
lib/identity/libs/bjj/bip32_derivation.dart New minimal BIP32 derivation implementation replacing bip32 package
lib/common/utils/push_service.dart Added custom RSA public key PEM parser replacing encrypt package functionality
test/identity/data/data_sources/encryption_db_data_source_test.dart Updated tests to use new encryption classes instead of mockito mocks
test/common/utils/push_service_test.dart New test file for RSA PEM parsing functionality
lib/sdk/di/injector.config.dart Auto-generated dependency injection configuration updates
Multiple .g.dart files Auto-generated JSON serialization code formatting changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 45.03311% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.11%. Comparing base (e37c1ce) to head (2773d0a).

Files with missing lines Patch % Lines
lib/identity/libs/bjj/bip32_derivation.dart 0.00% 33 Missing ⚠️
lib/common/crypto/symmetric.dart 52.45% 29 Missing ⚠️
lib/common/utils/encrypt_sembast_codec.dart 0.00% 10 Missing ⚠️
lib/common/utils/push_service.dart 83.33% 6 Missing ⚠️
lib/identity/libs/bjj/bjj_wallet.dart 0.00% 3 Missing ⚠️
lib/common/kms/key_providers/bjj_provider.dart 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #517      +/-   ##
===========================================
+ Coverage    18.66%   19.11%   +0.45%     
===========================================
  Files          298      300       +2     
  Lines         8968     9081     +113     
===========================================
+ Hits          1674     1736      +62     
- Misses        7294     7345      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@5eeman 5eeman merged commit 7237293 into develop Oct 28, 2025
3 checks passed
@5eeman 5eeman deleted the chore/packages_update branch October 28, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants