eth, core: handle state-sync data in eth/69 messages #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manav2401
changed the title
lucca30
reviewed
Aug 27, 2025
manav2401
commented
Aug 27, 2025
Comment on lines
+12
to
+15
| borReceiptsCacheHit = metrics.NewRegisteredGauge("bor/receipts/cache/hit", nil) | ||
| borReceiptsCacheMiss = metrics.NewRegisteredGauge("bor/receipts/cache/miss", nil) | ||
| borReceiptsRLPCacheHit = metrics.NewRegisteredGauge("bor/rlpreceipts/cache/hit", nil) | ||
| borReceiptsRLPCacheMiss = metrics.NewRegisteredGauge("bor/rlpreceipts/cache/miss", nil) |
There was a problem hiding this comment.
These metrics have been added to see the hit/miss ratio. For normal receipts, they've been removed from upstream. If the ratio is bad, probably worth removing for bor receipts as well.
lucca30
approved these changes
Aug 27, 2025
manav2401
commented
Sep 29, 2025
| if header.EmptyReceipts() && !isSprintEndBlock(borCfg, header.Number.Uint64()) { | ||
| fetchReceipts = false | ||
| } | ||
| if syncMode == SnapSync && fetchReceipts { |
There was a problem hiding this comment.
Will be writing a new test around this change.
This was referenced Sep 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to send state-sync transaction receipts (or bor receipts in short) in
eth/69protocol (which is newly added from upstream). This will allow nodes using snap sync to persist the state-sync transaction receipts (as there's no execution involved in snap sync and hence they're not generated locally).This PR changes the implementation of 2 p2p messages:
Moreover, this PR also changes how receipts are handled in
InsertReceiptChainfunction which didn't handle bor receipts earlier. Bor receipts can be identified by their 0 gas used field. Upon insertion, as they're stored separately from normal block receipts, they need to be extracted from the encoded packet which is handled in this PR.Note that this change is forward compatible and allows to do a hard fork in future where we include bor receipts as a part of receipt root without any p2p changes.
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it