Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed versions for pyproject #57

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Conversation

gabrielfior
Copy link
Contributor

We are using subgrounds for our data fetching on Gnosis. It would be great to have these new dependencies in-place.

@gabrielfior gabrielfior marked this pull request as ready for review June 17, 2024 21:49
@0xMochan 0xMochan merged commit cbf47e2 into 0xPlaygrounds:main Jun 18, 2024
1 of 2 checks passed
@0xMochan
Copy link
Collaborator

0xMochan commented Jun 18, 2024

Unfortuntely, I messed up the squash somehow but I've merged this!

@gabrielfior
Copy link
Contributor Author

@0xMochan thanks for merging!
I want to integrate these changes with my package (using poetry), but the last released version was 1.8.1 (see https://pypi.org/project/subgrounds/#history). Are you planning to release a new version soon with these changes? Thanks

@0xMochan
Copy link
Collaborator

ah, i didn't realize our auto-release flow didn't trigger. I'll look into it!

@0xMochan
Copy link
Collaborator

0xMochan commented Jun 18, 2024

hmm, actually can you explain more why you needed some of the dependencies to be a bit newer. the ^ symbol for versions should allow for newer patch versions if a project depending on subgrounds require it, as long as it's specified in a downstream pyproject.toml. There's not a specific requirement for subgrounds to be using newer versions in libs like pydantic.

The lack of pypi releases was due to a lack of verification on our emails. Not sure how the CI didn't fail for this as I haven't noticed this but I've resolved it now.

@gabrielfior
Copy link
Contributor Author

hmm, actually can you explain more why you needed some of the dependencies to be a bit newer. the ^ symbol for versions should allow for newer patch versions if a project depending on subgrounds require it, as long as it's specified in a downstream pyproject.toml. There's not a specific requirement for subgrounds to be using newer versions in libs like pydantic.

That was an error from my side. Your reasoning is correct - being more strict on Pydantic does not help. I created a PR (#58 ) to fix this.

The lack of pypi releases was due to a lack of verification on our emails. Not sure how the CI didn't fail for this as I haven't noticed this but I've resolved it now.

It would be great to have a published package for this new version (1.9.1) soon, as we want to point our poetry dependency to the new release on PyPI (for some reason, publishing a PyPI package which has a dependency of type {git=<GITHUB_REPO>, rev=""} makes poetry publish throw an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants