Skip to content

Rename Fixing activity bucket to PR and remap skills#122

Merged
0101 merged 3 commits into
mainfrom
execskill
Jul 17, 2026
Merged

Rename Fixing activity bucket to PR and remap skills#122
0101 merged 3 commits into
mainfrom
execskill

Conversation

@0101

@0101 0101 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Problem

The Overview band's agent activity breakdown had a Fixing bucket that no longer matched how coding tools are actually used. The pr skill was classified as Reviewing, and several skills (research, execute, babysit-pr, github) had no dedicated home, so PR-related work was spread across unrelated buckets.

Changes

  • Rename CurrentActivity.FixingCurrentActivity.PR in src/Shared/Types.fs, with a matching label (PR), CSS class (activity-pr), and canonical ordering update in the client (OverviewBand.fs, OverviewData.fs, index.html).
  • Remap the skill-to-activity classifier (Shared.Activity.classify):
    • PRbabysit-pr, pr, github, fix-build (pr moved out of Reviewing; fix-build moved out of the old fixing group).
    • Investigating — adds research.
    • Executing — adds execute.
    • Planning — drops spec-management.
    • conflict now falls through to the Working fallback.
  • Update the spec docs/spec/beads-overview-band.md (palette, skill table, and DU definition) to describe the PR bucket.
  • Update tests in ActivityClassifierTests.fs, OverviewDataTests.fs, and OverviewBandE2ETests.fs to cover the renamed bucket and the new skill mappings.

Tests

Targeted unit tests to be validated by CI (ActivityClassifierTests, OverviewDataTests).

Rename the CurrentActivity.Fixing case to CurrentActivity.PR and revise the skill-to-activity classifier: move 'pr' out of Reviewing into the new PR bucket alongside 'babysit-pr', 'github', and 'fix-build'; add 'research' to Investigating and 'execute' to Executing; drop 'spec-management' from Planning and 'conflict' from the fixing group (now Working). Updates the Shared classifier, client labels/CSS classes, spec doc, and all tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0d4095fd-8b57-498b-bbff-700ba6ccbf24
Copilot AI review requested due to automatic review settings July 17, 2026 13:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the Fixing activity bucket to PR and updates skill classification across shared logic, UI, documentation, and tests.

Changes:

  • Replaces CurrentActivity.Fixing with PR.
  • Remaps PR, research, execution, and fallback skills.
  • Updates UI labels, styling, specifications, and coverage.
Show a summary per file
File Description
src/Shared/Types.fs Renames the activity and updates classification.
src/Client/OverviewData.fs Updates canonical activity ordering.
src/Client/OverviewBand.fs Adds the PR label and CSS class.
src/Client/index.html Renames the activity color class.
src/Tests/ActivityClassifierTests.fs Updates classifier expectations.
src/Tests/OverviewDataTests.fs Updates aggregation expectations.
src/Tests/OverviewBandE2ETests.fs Updates the empty-bucket probe.
docs/spec/beads-overview-band.md Documents the PR bucket and mappings.

Review details

  • Files reviewed: 8/8 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread src/Tests/ActivityClassifierTests.fs
Comment thread src/Tests/OverviewBandE2ETests.fs
0101 and others added 2 commits July 17, 2026 16:23
The E2E suite only asserted the PR bucket was omitted when empty; the
renamed PR label, activity-pr class and peach accent were never rendered
or checked. Add a PR-skill agent to the fixture and assert its label,
class and computed colour, and move Step 6's zero-count example to the
still-empty Executing bucket.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 961396bf-e253-4449-b25e-fdc0e4551ccb
@0101
0101 enabled auto-merge (squash) July 17, 2026 14:25
@0101
0101 merged commit 3065853 into main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants