Skip to content

Commit 9b5ca86

Browse files
Subhasish-Beherazormit
Subhasish-Behera
andcommitted
tests: boxes: Ensure recipient box when editing is not writeable.
Co-authored-by: zormit <[email protected]>
1 parent abab4f4 commit 9b5ca86

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

tests/ui_tools/test_boxes.py

+13-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pytest
66
from pytest import param as case
77
from pytest_mock import MockerFixture
8-
from urwid import Widget
8+
from urwid import Text, Widget
99
from urwid_readline import ReadlineEdit
1010

1111
from zulipterminal.api_types import (
@@ -1704,7 +1704,10 @@ def test_keypress_CYCLE_COMPOSE_FOCUS(
17041704
else:
17051705
write_box.stream_box_view(stream_id)
17061706
else:
1707-
write_box.private_box_view()
1707+
if message_being_edited:
1708+
write_box.private_box_edit_view()
1709+
else:
1710+
write_box.private_box_view()
17081711
size = widget_size(write_box)
17091712

17101713
def focus_val(x: str) -> int:
@@ -1730,6 +1733,7 @@ def focus_val(x: str) -> int:
17301733
expected_focus_col_name
17311734
)
17321735

1736+
@pytest.mark.parametrize("message_being_edited", [(True), (False)])
17331737
@pytest.mark.parametrize(
17341738
"recipient_ids, expected_recipient_text",
17351739
[
@@ -1749,14 +1753,19 @@ def test_private_box_recipient_editing(
17491753
user_id_email_dict: Dict[int, str],
17501754
recipient_ids: List[int],
17511755
expected_recipient_text: str,
1756+
message_being_edited: bool,
17521757
) -> None:
17531758
write_box.model.user_id_email_dict = user_id_email_dict
17541759
write_box.model.user_dict = user_dict
17551760
mocker.patch("urwid.connect_signal")
17561761

1757-
write_box.private_box_view(recipient_user_ids=recipient_ids)
1762+
if message_being_edited:
1763+
write_box.private_box_edit_view(recipient_user_ids=recipient_ids)
1764+
assert isinstance(write_box.to_write_box, Text)
1765+
else:
1766+
write_box.private_box_view(recipient_user_ids=recipient_ids)
1767+
assert isinstance(write_box.to_write_box, ReadlineEdit)
17581768

1759-
assert isinstance(write_box.to_write_box, ReadlineEdit)
17601769
assert write_box.to_write_box.text == expected_recipient_text
17611770

17621771
@pytest.mark.parametrize("key", keys_for_command("MARKDOWN_HELP"))

0 commit comments

Comments
 (0)