[Android] Navigating back with gesture navigation opens action sheet

[jossiwolf]

Hi,

When navigating back from a stream using Android's back gesture navigation (swiping from an edge), the action sheet opens.
I suspect there might be a long press listener or incorrectly configured gesture detector that gets invoked here.

It's possible this is a React Native issue that should be filed upstream but I don't know enough about this :)

Seeing this on a Pixel 6 Pro on Android 13, previously saw it on a Pixel 6 on Android 12 and Android 13.

Zulip v27.191

Let me know if there's anything else that helps y'all debug!

zulipbug.mp4

[gnprice]

Thanks @jossiwolf for the report! I've actually been seeing this a version of this myself for a while now (since at least 2022-01), and have kept meaning to file an issue for it -- so thank you for doing so and for the helpful screen capture :-)

There's actually an intriguing difference between the symptoms you're seeing and the ones I've been seeing, though:

• In your video, it looks like you get the action sheet, but nothing else happens -- in particular, you don't end up actually navigating back.
• In my experience, I always do see a navigation back as expected. It's just that I also get, inappropriately, an action sheet showing up. (So the action sheet ends up showing in front of the previous screen, usually the inbox.)

Another difference:

• In your video, it looks like the action sheet disappears on its own, shortly after it appears -- it doesn't look like you take any action to dismiss it. (Am I understanding the video right?)
• In the symptoms I've been seeing, the action sheet sits there indefinitely waiting for me to interact, just as it (correctly) would if I'd summoned the action sheet in an intended way. I tap elsewhere on the screen to dismiss it.

The version you're experiencing seems a lot more annoying! In the version I see, the action sheet is clearly a glitch, but it doesn't much get it my way -- just an extra tap to get rid of it. In the version you see, the navigation gesture is completely defeated, so that you have to reach over to the "←" button at the top left in order to navigate back.

Have I understood things correctly?

FWIW, my observations are mainly on a Pixel 4 running Android 12. (Not sure offhand if I've also seen the issue on other devices.)

[jossiwolf]

Great observations! Navigating back actually works - I just cancelled the gesture to show that the sheet still gets shown. I'm seeing the same though; regardless of whether the gesture is completed and the back stack popped or the gesture is cancelled and the back stack not modified.

In your video, it looks like the action sheet disappears on its own, shortly after it appears -- it doesn't look like you take any action to dismiss it. (Am I understanding the video right?)

That's right! The recording shows performing a gesture and completing it. This is the correct behavior as the sheet is the topmost navigation destination when we complete the gesture, and we'd want to hide it when the user wants to navigate back.

The version you're experiencing seems a lot more annoying! In the version I see, the action sheet is clearly a glitch, but it doesn't much get it my way -- just an extra tap to get rid of it. In the version you see, the navigation gesture is completely defeated, so that you have to reach over to the "←" button at the top left in order to navigate back.

Pretty much. Completing the gesture in less time than the long click listener trigger works fine :-)

Sometimes navigation and the sheet race each other. Given end_gesture > start_gesture + long_click_trigger

• If end_gesture > start_gesture + long_click_trigger + sheet_animation_duration, the topmost back stack entry will be the bottom sheet when the back stack is popped.
• If end_gesture < start_gesture + long_click_trigger + sheet_animation_duration, the topmost back stack entry will still be the current screen. In the recording above, that would be the chat screen. When the back stack is popped, the sheet animation might still be running or the sheet not yet added to the back stack. That means we navigate back to the previous screen and then show the sheet. That's a bit harder to repro though :)

[jossiwolf]

Hi, just wanted to ping and see if there's anything I can do to support :)