KaTeX (4/n): Ignore classes that don't have CSS definition #1601
Conversation
rajveermalviya
changed the title
rajveermalviya
added
the
maintainer review
|
Thanks! The new commit here atop #1559: looks like it's pretty simple and should be fairly easy to merge. After you split up #1452 as described at #1452 (comment), would you rebase this to be atop that first segment? (It looks like it'd conflict with one of the commits there, so that seems like the simplest way to handle the conflict.) If these PRs were new, I'd suggest instead squashing this into the similar commit in #1452. But given that previous revisions of #1452 have been out in releases now, I think it'll be good to avoid adding new functionality to #1452, and put it in new PRs instead, like this one — that'll help us keep track of what's changed from one release in a crisp way. |
rajveermalviya
force-pushed
the
pr-tex-content-4
branch
2 times, most recently
from
dfc036d to
c34a6e1
Compare
rajveermalviya
force-pushed
the
pr-tex-content-4
branch
from
c34a6e1 to
2bb1c37
Compare
|
Updated to add |
|
I've included this PR in today's release 259: #announce > mobile releases @ 💬. (I cherry-picked its one commit into the release branch; the previous commits' changes were included in the previous release 258, as part of #1452.) To copy into this thread what we found in chat (#mobile-team > KaTeX survey results @ 💬) using the survey script #1600: on a corpus from an open Zulip community about math,
|
gnprice
added
integration review
| case 'mbin': | ||
| case 'mpunct': | ||
| case 'nobreak': | ||
| case 'allowbreak': | ||
| case 'mathdefault': |
There was a problem hiding this comment.
This change looks good, but leaves it still a bit mysterious why these classes are there in the KaTeX output if we really don't need to do anything about them.
As it happens, while I was reviewing #1609 earlier today I came across a couple of threads in the KaTeX tracker that basically answer that question. So I've just pushed a commit on top which adds a comment linking to those:
cbeef34 content [nfc]: Explain why some KaTeX CSS classes are unused in its CSS
|
This is ready to merge as soon as #1609 is merged. |
|
And merged, after rebasing atop the merged #1609. |
Stacked on top of #1609.