Skip to content

Commit 9c9c231

Browse files
committed
NOMERGE home [nfc]: Make MenuButton public
lib/widgets/button.dart is probably better as a home for this; would need some dartdoc/etc.
1 parent e096c46 commit 9c9c231

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

lib/widgets/home.dart

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -330,8 +330,8 @@ void _showMainMenu(BuildContext context, {
330330
});
331331
}
332332

333-
abstract class _MenuButton extends StatelessWidget {
334-
const _MenuButton();
333+
abstract class MenuButton extends StatelessWidget {
334+
const MenuButton({super.key});
335335

336336
String label(ZulipLocalizations zulipLocalizations);
337337

@@ -342,12 +342,12 @@ abstract class _MenuButton extends StatelessWidget {
342342
/// Must be non-null unless [buildLeading] is overridden.
343343
IconData? get icon;
344344

345-
static const _iconSize = 24.0;
345+
static const iconSize = 24.0;
346346

347347
Widget buildLeading(BuildContext context) {
348348
assert(icon != null);
349349
final designVariables = DesignVariables.of(context);
350-
return Icon(icon, size: _iconSize,
350+
return Icon(icon, size: iconSize,
351351
color: selected ? designVariables.iconSelected : designVariables.icon);
352352
}
353353

@@ -400,7 +400,7 @@ abstract class _MenuButton extends StatelessWidget {
400400
onPressed: () => _handlePress(context),
401401
style: buttonStyle,
402402
child: Row(spacing: 8, children: [
403-
SizedBox.square(dimension: _iconSize,
403+
SizedBox.square(dimension: iconSize,
404404
child: buildLeading(context)),
405405
Expanded(child: Text(label(zulipLocalizations),
406406
// TODO(design): determine if we prefer to wrap
@@ -412,7 +412,7 @@ abstract class _MenuButton extends StatelessWidget {
412412
}
413413

414414
/// A menu button controlling the selected [_HomePageTab] on the bottom nav bar.
415-
abstract class _NavigationBarMenuButton extends _MenuButton {
415+
abstract class _NavigationBarMenuButton extends MenuButton {
416416
const _NavigationBarMenuButton({required this.tabNotifier});
417417

418418
final ValueNotifier<_HomePageTab> tabNotifier;
@@ -428,7 +428,7 @@ abstract class _NavigationBarMenuButton extends _MenuButton {
428428
}
429429
}
430430

431-
class _SearchButton extends _MenuButton {
431+
class _SearchButton extends MenuButton {
432432
const _SearchButton();
433433

434434
@override
@@ -461,7 +461,7 @@ class _InboxButton extends _NavigationBarMenuButton {
461461
_HomePageTab get navigationTarget => _HomePageTab.inbox;
462462
}
463463

464-
class _MentionsButton extends _MenuButton {
464+
class _MentionsButton extends MenuButton {
465465
const _MentionsButton();
466466

467467
@override
@@ -479,7 +479,7 @@ class _MentionsButton extends _MenuButton {
479479
}
480480
}
481481

482-
class _StarredMessagesButton extends _MenuButton {
482+
class _StarredMessagesButton extends MenuButton {
483483
const _StarredMessagesButton();
484484

485485
@override
@@ -497,7 +497,7 @@ class _StarredMessagesButton extends _MenuButton {
497497
}
498498
}
499499

500-
class _CombinedFeedButton extends _MenuButton {
500+
class _CombinedFeedButton extends MenuButton {
501501
const _CombinedFeedButton();
502502

503503
@override
@@ -545,7 +545,7 @@ class _DirectMessagesButton extends _NavigationBarMenuButton {
545545
_HomePageTab get navigationTarget => _HomePageTab.directMessages;
546546
}
547547

548-
class _MyProfileButton extends _MenuButton {
548+
class _MyProfileButton extends MenuButton {
549549
const _MyProfileButton();
550550

551551
@override
@@ -556,7 +556,7 @@ class _MyProfileButton extends _MenuButton {
556556
final store = PerAccountStoreWidget.of(context);
557557
return Avatar(
558558
userId: store.selfUserId,
559-
size: _MenuButton._iconSize,
559+
size: MenuButton.iconSize,
560560
borderRadius: 4,
561561
showPresence: false,
562562
);
@@ -575,7 +575,7 @@ class _MyProfileButton extends _MenuButton {
575575
}
576576
}
577577

578-
class _SwitchAccountButton extends _MenuButton {
578+
class _SwitchAccountButton extends MenuButton {
579579
const _SwitchAccountButton();
580580

581581
@override
@@ -592,7 +592,7 @@ class _SwitchAccountButton extends _MenuButton {
592592
}
593593
}
594594

595-
class _SettingsButton extends _MenuButton {
595+
class _SettingsButton extends MenuButton {
596596
const _SettingsButton();
597597

598598
@override
@@ -609,7 +609,7 @@ class _SettingsButton extends _MenuButton {
609609
}
610610
}
611611

612-
class _AboutZulipButton extends _MenuButton {
612+
class _AboutZulipButton extends MenuButton {
613613
const _AboutZulipButton();
614614

615615
@override

0 commit comments

Comments
 (0)