Skip to content

Commit 1fde9e9

Browse files
committed
bridge_with_slack: Do not use a stale Zulip client for send_message.
1 parent 7bebd7d commit 1fde9e9

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

Diff for: zulip/integrations/bridge_with_slack/run-slack-bridge

+12-6
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,17 @@ class SlackBridge:
5353
}
5454

5555
# zulip-specific
56-
self.zulip_client = zulip.Client(
57-
email=self.zulip_config["email"],
58-
api_key=self.zulip_config["api_key"],
59-
site=self.zulip_config["site"],
60-
)
56+
def zulip_client_constructor() -> zulip.Client:
57+
return zulip.Client(
58+
email=self.zulip_config["email"],
59+
api_key=self.zulip_config["api_key"],
60+
site=self.zulip_config["site"],
61+
)
62+
63+
self.zulip_client = zulip_client_constructor()
64+
# Temporary workaround until
65+
# https://github.com/zulip/python-zulip-api/issues/761 is fixed.
66+
self.zulip_client_constructor = zulip_client_constructor
6167

6268
# slack-specific
6369
self.slack_client = rtm
@@ -121,7 +127,7 @@ class SlackBridge:
121127
subject=zulip_endpoint["topic"],
122128
content=content,
123129
)
124-
self.zulip_client.send_message(msg_data)
130+
self.zulip_client_constructor().send_message(msg_data)
125131

126132
self.slack_client.start()
127133

Diff for: zulip_bots/zulip_bots/bots/stack_overflow/stack_overflow.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import logging
22
from typing import Dict, Final, Optional
3+
||||||| Stash base
34

45
import requests
56

0 commit comments

Comments
 (0)