chore: Update linter rules and address all warnings

Author: zulfahmi93

Diff for: analysis_options.yaml

@@ -1,85 +1 @@
-include: package:flutter_lints/flutter.yaml
-
-analyzer:
-  exclude:
-    - build/**
-    - lib/*.g.dart
-    - lib/*.freezed.dart
-    - lib/**/*.g.dart
-    - lib/**/*.freezed.dart
-    - lib/**/*.gr.dart
-    - lib/generated_plugin_registrant.dart
-    - shared_components/**/*.*
-
-linter:
-  rules:
-    # STYLE
-    - camel_case_types
-    - camel_case_extensions
-    - library_names
-    - file_names
-    - library_prefixes
-    - non_constant_identifier_names
-    - constant_identifier_names
-    - directives_ordering
-    - lines_longer_than_80_chars
-    - curly_braces_in_flow_control_structures
-    - sort_pub_dependencies
-    - prefer_single_quotes
-    - always_declare_return_types
-
-    # DOCUMENTATION
-    - slash_for_doc_comments
-    - package_api_docs
-    # - public_member_api_docs
-    #- comment_references # Unused because https://github.com/dart-lang/sdk/issues/36974
-
-    # USAGE
-    - implementation_imports
-    - avoid_relative_lib_imports
-    - prefer_relative_imports
-    - prefer_adjacent_string_concatenation
-    - prefer_interpolation_to_compose_strings
-    - unnecessary_brace_in_string_interps
-    - prefer_collection_literals
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - avoid_function_literals_in_foreach_calls
-    - prefer_iterable_whereType
-    - prefer_function_declarations_over_variables
-    - unnecessary_lambdas
-    - avoid_init_to_null
-    - unnecessary_getters_setters
-    #- unnecessary_getters # prefer # Disabled pending fix: https://github.com/dart-lang/linter/issues/23
-    - unnecessary_this
-    - prefer_initializing_formals
-    - type_init_formals
-    - empty_constructor_bodies
-    - unnecessary_new
-    - unnecessary_const
-    - avoid_catches_without_on_clauses
-    - avoid_catching_errors
-    - use_rethrow_when_possible
-
-    # DESIGN
-    - use_to_and_as_if_applicable
-    - one_member_abstracts
-    - avoid_classes_with_only_static_members
-    - prefer_mixin
-    - prefer_final_fields
-    - use_setters_to_change_properties
-    - avoid_setters_without_getters
-    - avoid_returning_null
-    - avoid_returning_this
-    - type_annotate_public_apis
-    - prefer_typing_uninitialized_variables
-    - omit_local_variable_types
-    - avoid_types_on_closure_parameters
-    - avoid_return_types_on_setters
-    - prefer_generic_function_type_aliases
-    - avoid_private_typedef_functions
-    - use_function_type_syntax_for_parameters
-    - avoid_positional_boolean_parameters
-    - hash_and_equals
-    - avoid_equals_and_hash_code_on_mutable_classes
-    - avoid_null_checks_in_equality_operators
+include: ../analysis_options.yaml

Diff for: example/analysis_options.yaml

@@ -10,8 +10,8 @@ void main() {
 class ExampleApp extends StatelessWidget {
   // ------------------------------- CONSTRUCTORS ------------------------------
   const ExampleApp({
-    Key? key,
-  }) : super(key: key);
+    super.key,
+  });
 
   // --------------------------------- METHODS ---------------------------------
   @override
@@ -31,8 +31,8 @@ class ExampleApp extends StatelessWidget {
 class MyHomePage extends StatefulWidget {
   // ------------------------------- CONSTRUCTORS ------------------------------
   const MyHomePage({
-    Key? key,
-  }) : super(key: key);
+    super.key,
+  });
 
   // --------------------------------- METHODS ---------------------------------
   @override
@@ -58,15 +58,15 @@ class _MyHomePageState extends State<MyHomePage> {
               Text(DateFormat().add_yM().format(_selected!)),
             TextButton(
               child: const Text('DEFAULT LOCALE'),
-              onPressed: () => _onPressed(context: context),
+              onPressed: () async => _onPressed(context: context),
             ),
             TextButton(
               child: const Text('BAHASA MALAYSIA'),
-              onPressed: () => _onPressed(context: context, locale: 'ms'),
+              onPressed: () async => _onPressed(context: context, locale: 'ms'),
             ),
             TextButton(
               child: const Text('اللغة العربية'),
-              onPressed: () => _onPressed(context: context, locale: 'ar'),
+              onPressed: () async => _onPressed(context: context, locale: 'ar'),
             ),
           ],
         ),

Diff for: example/lib/main.dart

@@ -1,4 +1,2 @@
-library month_year_picker;
-
 export 'src/dialogs.dart';
 export 'src/l10n/month_year_picker_localizations.dart';

Diff for: lib/month_year_picker.dart

@@ -1,5 +1,4 @@
-import 'dart:math' as math;
-
+import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart' hide YearPicker;
 
 import 'l10n/month_year_picker_localizations.dart';
@@ -31,7 +30,7 @@ Future<DateTime?> showMonthYearPicker({
   TextDirection? textDirection,
   TransitionBuilder? builder,
   MonthYearPickerMode initialMonthYearPickerMode = MonthYearPickerMode.month,
-}) async {
+}) {
   initialDate = monthYearOnly(initialDate);
   firstDate = monthYearOnly(firstDate);
   lastDate = monthYearOnly(lastDate);
@@ -48,9 +47,18 @@ Future<DateTime?> showMonthYearPicker({
     !initialDate.isAfter(lastDate),
     'initialDate $initialDate must be on or before lastDate $lastDate.',
   );
-  assert(debugCheckHasMaterialLocalizations(context));
-  assert(debugCheckHasMonthYearPickerLocalizations(context));
-  assert(debugCheckHasDirectionality(context));
+  assert(
+    debugCheckHasMaterialLocalizations(context),
+    'No MaterialLocalizations found.',
+  );
+  assert(
+    debugCheckHasMonthYearPickerLocalizations(context),
+    'No MonthYearPickerLocalizations found.',
+  );
+  assert(
+    debugCheckHasDirectionality(context),
+    'No Directionality found.',
+  );
 
   Widget dialog = MonthYearPickerDialog(
     initialDate: initialDate,
@@ -75,7 +83,7 @@ Future<DateTime?> showMonthYearPicker({
     );
   }
 
-  return await showDialog<DateTime>(
+  return showDialog<DateTime>(
     context: context,
     useRootNavigator: useRootNavigator,
     routeSettings: routeSettings,
@@ -93,13 +101,13 @@ enum MonthYearPickerMode {
 class MonthYearPickerDialog extends StatefulWidget {
   // ------------------------------- CONSTRUCTORS ------------------------------
   const MonthYearPickerDialog({
-    Key? key,
+    super.key,
     required this.initialDate,
     required this.firstDate,
     required this.lastDate,
     required this.initialMonthYearPickerMode,
     this.selectableMonthYearPredicate,
-  }) : super(key: key);
+  });
 
   // ---------------------------------- FIELDS ---------------------------------
   final DateTime initialDate;
@@ -111,6 +119,27 @@ class MonthYearPickerDialog extends StatefulWidget {
   // --------------------------------- METHODS ---------------------------------
   @override
   State<MonthYearPickerDialog> createState() => _MonthYearPickerDialogState();
+
+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
+    properties
+      ..add(DiagnosticsProperty<DateTime>('initialDate', initialDate))
+      ..add(DiagnosticsProperty<DateTime>('firstDate', firstDate))
+      ..add(DiagnosticsProperty<DateTime>('lastDate', lastDate))
+      ..add(
+        EnumProperty<MonthYearPickerMode>(
+          'initialMonthYearPickerMode',
+          initialMonthYearPickerMode,
+        ),
+      )
+      ..add(
+        ObjectFlagProperty<SelectableMonthYearPredicate?>.has(
+          'selectableMonthYearPredicate',
+          selectableMonthYearPredicate,
+        ),
+      );
+  }
 }
 
 class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
@@ -159,7 +188,7 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
     final textTheme = theme.textTheme;
     // Constrain the textScaleFactor to the largest supported value to prevent
     // layout issues.
-    final textScaleFactor = math.min(media.textScaleFactor, 1.3);
+    final textScaler = media.textScaler;
     final direction = Directionality.of(context);
 
     final dateText = materialLocalizations.formatMonthYear(_selectedDate);
@@ -248,7 +277,7 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
                       : Icons.keyboard_arrow_right,
                 ),
                 onPressed: _canGoNext ? _goToNextPage : null,
-              )
+              ),
             ],
           ),
         ),
@@ -270,7 +299,7 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
               duration: _dialogSizeAnimationDuration,
               curve: Curves.easeOut,
               left: 0.0,
-              right: (pickerMaxWidth - (width ?? pickerMaxWidth)),
+              right: pickerMaxWidth - (width ?? pickerMaxWidth),
               top: _isShowingYear ? 0.0 : -constraints.maxHeight,
               bottom: _isShowingYear ? 0.0 : constraints.maxHeight,
               child: SizedBox(
@@ -292,7 +321,7 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
               duration: _dialogSizeAnimationDuration,
               curve: Curves.easeOut,
               left: 0.0,
-              right: (pickerMaxWidth - (width ?? pickerMaxWidth)),
+              right: pickerMaxWidth - (width ?? pickerMaxWidth),
               top: _isShowingYear ? constraints.maxHeight : 0.0,
               bottom: _isShowingYear ? -constraints.maxHeight : 0.0,
               child: SizedBox(
@@ -309,13 +338,12 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
                       widget.selectableMonthYearPredicate,
                 ),
               ),
-            )
+            ),
           ],
         );
       },
     );
 
-    final dialogSize = _dialogSize * textScaleFactor;
     return Directionality(
       textDirection: direction,
       child: Dialog(
@@ -325,14 +353,12 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
         ),
         clipBehavior: Clip.antiAlias,
         child: AnimatedContainer(
-          width: dialogSize.width,
-          height: dialogSize.height,
+          width: textScaler.scale(_dialogSize.width),
+          height: textScaler.scale(_dialogSize.height),
           duration: _dialogSizeAnimationDuration,
           curve: Curves.easeIn,
           child: MediaQuery(
-            data: MediaQuery.of(context).copyWith(
-              textScaleFactor: textScaleFactor,
-            ),
+            data: MediaQuery.of(context).copyWith(textScaler: textScaler),
             child: Builder(
               builder: (context) {
                 switch (orientation) {
@@ -406,33 +432,24 @@ class _MonthYearPickerDialogState extends State<MonthYearPickerDialog> {
     }
   }
 
-  void _goToPreviousPage() {
-    if (_isShowingYear) {
-      _yearPickerState.currentState!.goDown();
-    } else {
-      _monthPickerState.currentState!.goDown();
-    }
-  }
+  Future<void> _goToPreviousPage() => _isShowingYear
+      ? _yearPickerState.currentState!.goDown()
+      : _monthPickerState.currentState!.goDown();
 
-  void _goToNextPage() {
-    if (_isShowingYear) {
-      _yearPickerState.currentState!.goUp();
-    } else {
-      _monthPickerState.currentState!.goUp();
-    }
-  }
+  Future<void> _goToNextPage() => _isShowingYear
+      ? _yearPickerState.currentState!.goUp()
+      : _monthPickerState.currentState!.goUp();
 }
 
 class _Header extends StatelessWidget {
   // ------------------------------- CONSTRUCTORS ------------------------------
   const _Header({
-    Key? key,
     required this.helpText,
     required this.titleText,
     this.titleSemanticsLabel,
     required this.titleStyle,
     required this.orientation,
-  }) : super(key: key);
+  });
 
   // ---------------------------------- FIELDS ---------------------------------
   final String helpText;
@@ -528,4 +545,15 @@ class _Header extends StatelessWidget {
         );
     }
   }
+
+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
+    properties
+      ..add(StringProperty('helpText', helpText))
+      ..add(StringProperty('titleText', titleText))
+      ..add(StringProperty('titleSemanticsLabel', titleSemanticsLabel))
+      ..add(DiagnosticsProperty<TextStyle?>('titleStyle', titleStyle))
+      ..add(EnumProperty<Orientation>('orientation', orientation));
+  }
 }