(UPDATE) add explicit language codes validation in favor of keeping default languages ordering in project #52
+42
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault languages ordering in project
jieter
reviewed
Apr 29, 2019
| if len(available_languages) != len(set(available_languages)): | ||
| raise ImproperlyConfigured( | ||
| "Languages should not contains duplicates: {}".format(available_languages) | ||
| ) |
Member
There was a problem hiding this comment.
This message should mention the setting a user should adjust in order to fix it (something like MODELTRANS_AVAILABLE_LANGUAGES or LANGUAGES should not contain duplicates)
Contributor
Author
There was a problem hiding this comment.
@jieter can you looks at this PR please?
dfirst
force-pushed
the
UPDATE_explicit_language_duplicates_validation
branch
from
8801d90 to
013fa26
Compare
dfirst
force-pushed
the
UPDATE_explicit_language_duplicates_validation
branch
from
013fa26 to
fef6923
Compare
dfirst
force-pushed
the
UPDATE_explicit_language_duplicates_validation
branch
from
fef6923 to
fce5f72
Compare
dfirst
force-pushed
the
UPDATE_explicit_language_duplicates_validation
branch
from
baa56d2 to
d8e03fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.