Add AbstractSelect::getFilterOptionsForDcGeneral

This method will always return the options list based on id instead of
alias.
Therefore we do not have problems anymore, when editing data in a
language different from the language the ui is using.
The problem was, when the select was referencing a translated MetaModel
and the configured alias column was also translated, then is was tried
to save an alias value in the language of the UI instead of the
currently active dataset rendering an exception to be thrown as the
select attribute does not accept the value (it does not know about).

Author: discordier

src/MetaModels/Attribute/Select/AbstractSelect.php

@@ -161,6 +161,15 @@ protected function isFilterOptionRetrievingPossible($idList)
         return $this->isProperlyConfigured() && (($idList === null) || !empty($idList));
     }
 
+    /**
+     * Obtain the filter options with always the id being contained instead of the alias.
+     *
+     * This is being called from BackendSubscriber to circumvent problems when dealing with translated aliases.
+     *
+     * @return array
+     */
+    abstract public function getFilterOptionsForDcGeneral();
+
     /**
      * {@inheritdoc}
      */

src/MetaModels/Attribute/Select/MetaModelSelect.php

@@ -148,9 +148,9 @@ protected function getValuesById($valueIds)
      */
     public function valueToWidget($varValue)
     {
-        if (isset($varValue[$this->getAliasColumn()])) {
+        if (isset($varValue[$this->getIdColumn()])) {
             // Hope the best that this is unique...
-            return (string) $varValue[$this->getAliasColumn()];
+            return (string) $varValue[$this->getIdColumn()];
         }
 
         if (isset($varValue[self::SELECT_RAW]['id'])) {
@@ -168,7 +168,7 @@ public function valueToWidget($varValue)
     public function widgetToValue($varValue, $itemId)
     {
         $model     = $this->getSelectMetaModel();
-        $alias     = $this->getAliasColumn();
+        $alias     = $this->getIdColumn();
         $attribute = $model->getAttribute($alias);
 
         if ($attribute) {
@@ -220,6 +220,32 @@ public function widgetToValue($varValue, $itemId)
         return $value[$valueId];
     }
 
+    /**
+     * {@inheritDoc}
+     *
+     * @SuppressWarnings(PHPMD.Superglobals)
+     * @SuppressWarnings(PHPMD.CamelCaseVariableName)
+     */
+    public function getFilterOptionsForDcGeneral()
+    {
+        if (!$this->isFilterOptionRetrievingPossible(null)) {
+            return array();
+        }
+
+        $originalLanguage       = $GLOBALS['TL_LANGUAGE'];
+        $GLOBALS['TL_LANGUAGE'] = $this->getMetaModel()->getActiveLanguage();
+
+        $filter = $this->getSelectMetaModel()->getEmptyFilter();
+
+        $this->buildFilterRulesForFilterSetting($filter);
+
+        $objItems = $this->getSelectMetaModel()->findByFilter($filter, $this->getSortingColumn());
+
+        $GLOBALS['TL_LANGUAGE'] = $originalLanguage;
+
+        return $this->convertItemsToFilterOptions($objItems, $this->getValueColumn(), $this->getIdColumn());
+    }
+
     /**
      * Fetch filter options from foreign table taking the given flag into account.
      *

src/MetaModels/Attribute/Select/Select.php

@@ -93,31 +93,36 @@ public function getAttributeSettingNames()
      */
     public function valueToWidget($varValue)
     {
-        $strColNameAlias = $this->get('select_alias');
-        if ($this->isTreePicker() || !$strColNameAlias) {
-            $strColNameAlias = $this->getIdColumn();
-        }
-
-        return $varValue[$strColNameAlias];
+        return $varValue[$this->getIdColumn()];
     }
 
     /**
      * {@inheritdoc}
      */
     public function widgetToValue($varValue, $itemId)
     {
-        $database        = $this->getDatabase();
-        $strColNameAlias = $this->getAliasColumn();
-        $strColNameId    = $this->getIdColumn();
-        if ($this->isTreePicker()) {
-            $strColNameAlias = $strColNameId;
-        }
-        // Lookup the id for this value.
-        $objValue = $database
-            ->prepare(sprintf('SELECT %1$s.* FROM %1$s WHERE %2$s=?', $this->getSelectSource(), $strColNameAlias))
+        // Lookup the value.
+        $values = $this->getDatabase()
+            ->prepare(sprintf('SELECT %1$s.* FROM %1$s WHERE %2$s=?', $this->getSelectSource(), $this->getIdColumn()))
             ->execute($varValue);
 
-        return $objValue->row();
+        return $values->row();
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @SuppressWarnings(PHPMD.Superglobals)
+     * @SuppressWarnings(PHPMD.CamelCaseVariableName)
+     */
+    public function getFilterOptionsForDcGeneral()
+    {
+        if (!$this->isFilterOptionRetrievingPossible(null)) {
+            return array();
+        }
+
+        $values = $this->getFilterOptionsForUsedOnly(false);
+        return $this->convertOptionsList($values, $this->getIdColumn(), $this->getValueColumn());
     }
 
     /**

src/MetaModels/DcGeneral/Events/MetaModels/Select/BackendSubscriber.php

@@ -61,7 +61,7 @@ public function getPropertyOptions(GetPropertyOptionsEvent $event)
         }
 
         try {
-            $options = $attribute->getFilterOptions(null, false);
+            $options = $attribute->getFilterOptionsForDcGeneral();
         } catch (\Exception $exception) {
             $options = array('Error: ' . $exception->getMessage());
         }