From 6cb4c283e76209d59c45fbcb218800cd19e9339d Mon Sep 17 00:00:00 2001
From: Peter Johanson <peter@peterjohanson.com>
Date: Thu, 3 Oct 2024 14:18:06 -0600
Subject: [PATCH] refactor: Return detailed save changes response.

* Include possible error codes/types when failing so save keymap
  changes.
---
 proto/zmk/behaviors.proto |  7 -------
 proto/zmk/keymap.proto    | 16 +++++++++++++++-
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/proto/zmk/behaviors.proto b/proto/zmk/behaviors.proto
index 03a1fac..ccdadac 100644
--- a/proto/zmk/behaviors.proto
+++ b/proto/zmk/behaviors.proto
@@ -30,13 +30,6 @@ message GetBehaviorDetailsResponse {
     repeated BehaviorBindingParametersSet metadata = 3;
 }
 
-enum BehaviorBindingParameterStandardDomain {
-    NIL = 0;
-    HID_USAGE = 1;
-    LAYER_ID = 2;
-    // HSV_VALUE = 3;
-}
-
 message BehaviorBindingParametersSet {
     repeated BehaviorParameterValueDescription param1 = 1;
     repeated BehaviorParameterValueDescription param2 = 2;
diff --git a/proto/zmk/keymap.proto b/proto/zmk/keymap.proto
index 01d8eb7..103bbf7 100644
--- a/proto/zmk/keymap.proto
+++ b/proto/zmk/keymap.proto
@@ -24,7 +24,7 @@ message Response {
         Keymap get_keymap = 1;
         SetLayerBindingResponse set_layer_binding = 2;
         bool check_unsaved_changes = 3;
-        bool save_changes = 4;
+        SaveChangesResponse save_changes = 4;
         bool discard_changes = 5;
         PhysicalLayouts get_physical_layouts = 6;
         SetActivePhysicalLayoutResponse set_active_physical_layout = 7;
@@ -42,6 +42,20 @@ message Notification {
     }
 }
 
+message SaveChangesResponse {
+    oneof result {
+        bool ok = 1;
+        SaveChangesErrorCode err = 2;
+    }
+}
+
+enum SaveChangesErrorCode {
+    SAVE_CHANGES_ERR_OK = 0;
+    SAVE_CHANGES_ERR_GENERIC = 1;
+    SAVE_CHANGES_ERR_NOT_SUPPORTED = 2;
+    SAVE_CHANGES_ERR_NO_SPACE = 3;
+}
+
 enum SetLayerBindingResponse {
     SET_LAYER_BINDING_RESP_OK = 0;
     SET_LAYER_BINDING_RESP_INVALID_LOCATION = 1;