Ensure disconnect can be called multiple times (#129)

* Ensure `disconnect` can be called even when the radio is disconnected

* Add unit tests

Author: puddly

tests/test_application.py

@@ -2,6 +2,7 @@
 from .async_mock import AsyncMock, MagicMock, patch, sentinel
 
 import pytest
+import logging
 import zigpy.types as zigpy_types
 import zigpy.exceptions
 
@@ -96,3 +97,41 @@ async def mock_get_network_state():
 
     with pytest.raises(zigpy.exceptions.FormationFailure):
         await app.form_network()
+
+
+@pytest.mark.asyncio
+async def test_disconnect_success(app):
+    api = MagicMock()
+
+    app._api = api
+    await app.disconnect()
+
+    api.close.assert_called_once()
+    assert app._api is None
+
+
+@pytest.mark.asyncio
+async def test_disconnect_failure(app, caplog):
+    api = MagicMock()
+    api.disconnect = MagicMock(side_effect=RuntimeError("Broken"))
+
+    app._api = api
+
+    with caplog.at_level(logging.WARNING):
+        await app.disconnect()
+
+    assert "disconnect" in caplog.text
+
+    api.close.assert_called_once()
+    assert app._api is None
+
+
+@pytest.mark.asyncio
+async def test_disconnect_multiple(app):
+    app._api = None
+
+    await app.disconnect()
+    await app.disconnect()
+    await app.disconnect()
+
+    assert app._api is None

zigpy_zigate/zigbee/application.py

@@ -49,11 +49,15 @@ async def connect(self):
 
     async def disconnect(self):
         # TODO: how do you stop the network? Is it possible?
-        await self._api.reset(wait=False)
 
-        if self._api:
-            self._api.close()
-            self._api = None
+        if self._api is not None:
+            try:
+                await self._api.reset(wait=False)
+            except Exception as e:
+                LOGGER.warning("Failed to reset before disconnect: %s", e)
+            finally:
+                self._api.close()
+                self._api = None
 
     async def start_network(self):
         # TODO: how do you start the network? Is it always automatically started?