-
Notifications
You must be signed in to change notification settings - Fork 13
Description
Probably need to update dependencies in setup.cfg plus possibly other source for isort or in other way seperate isort dependency for all zigpy libraries as upstream repo for isort has moved?
@Adminiuga This is only to bring this to your attention as I don't know the best solution for this, I just happened to stumble on the fact that the mirror of isort package for pre-commit is deprecated and that upstream isort has also recently been moved. I think that this applies to all zigpy libraries, including zigpy, bellows, zigpy-cc, zigpy-deconz, zigpy-xbee, zigpy-zigate, and zha-device-handlers, plus zigpy-znp as well?
For reference, updated now in zigpy, zigpy-deconz, and bellows:
See comment in https://github.com/pre-commit/mirrors-isort where is says that the pre-commit mirror for isort repository is deprecated, and to instead use isort directly.
Mirror of isort package for pre-commit split and moved
For pre-commit: see https://github.com/pre-commit/pre-commit
For isort: see https://github.com/PyCQA/isort
Also note that isort upstream recently moved from https://github.com/timothycrosley/isort to https://github.com/PyCQA/isort
Currently, the latest release is 5.5.0 (as of September 3, 2020) and since isort 5.0.0 and later it now requires Python 3.6 or later:
https://pycqa.github.io/isort/CHANGELOG/
Some more information should be available at https://pycqa.github.io/isort/
PS: If you decide on changing this then please also remember to reflect the changes in the CONTRIBUTING.md file for zigpy: