Skip to content

Commit 00a3125

Browse files
committed
Change cluster name to match dev.
1 parent 4cc25f9 commit 00a3125

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

zha/application/platforms/light/__init__.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
CLUSTER_HANDLER_LEVEL,
7373
CLUSTER_HANDLER_LEVEL_CHANGED,
7474
CLUSTER_HANDLER_ON_OFF,
75+
CLUSTER_HANDLER_PHILIPS_HUE_LIGHT,
7576
)
7677
from zha.zigbee.cluster_handlers.general import LevelChangeEvent
7778

@@ -996,7 +997,7 @@ class HueLight(Light):
996997
aux_cluster_handlers={
997998
CLUSTER_HANDLER_COLOR,
998999
CLUSTER_HANDLER_LEVEL,
999-
"philips_hue_cluster",
1000+
CLUSTER_HANDLER_PHILIPS_HUE_LIGHT,
10001001
},
10011002
manufacturers={"Philips", "Signify Netherlands B.V."},
10021003
)
@@ -1018,14 +1019,16 @@ def __init__(
10181019
) -> None:
10191020
"""Initialize the ZHA light."""
10201021
super().__init__(unique_id, cluster_handlers, endpoint, device, **kwargs)
1021-
self._hue_cluster = self.cluster_handlers.get("philips_hue_cluster")
1022+
self._hue_light_cluster = self.cluster_handlers.get(
1023+
CLUSTER_HANDLER_PHILIPS_HUE_LIGHT
1024+
)
10221025
self._effect_list.extend(self.HUE_EFFECTS.keys())
10231026

10241027
async def async_turn_on(self, **kwargs: Any) -> None:
10251028
"""Turn the entity on."""
1026-
# If only change of brightness is requested, the effect doesn't have to be interupted
1029+
# If only change of brightness is requested, the effect doesn't have to be interrupted
10271030
if kwargs.get(ATTR_BRIGHTNESS) is not None and all(
1028-
attr == ATTR_BRIGHTNESS or kwargs.get(attr) is None for attr in kwargs
1031+
kwargs.get(attr) is None for attr in (kwargs.keys() - {ATTR_BRIGHTNESS})
10291032
):
10301033
effect = self._effect
10311034
else:
@@ -1038,7 +1041,7 @@ async def async_turn_on(self, **kwargs: Any) -> None:
10381041

10391042
if effect in self.HUE_EFFECTS:
10401043
effect_id = self.HUE_EFFECTS[effect]
1041-
await self._hue_cluster.multicolor(
1044+
await self._hue_light_cluster.multicolor(
10421045
data=bytearray([0x22, 0x00, self._brightness, effect_id])
10431046
)
10441047
self._effect = effect
@@ -1047,7 +1050,9 @@ async def async_turn_on(self, **kwargs: Any) -> None:
10471050
) and self._effect in self.HUE_EFFECTS:
10481051
# Only stop effect if it was started by us
10491052
# Following command will stop the effect while preserving brightness
1050-
await self._hue_cluster.multicolor(data=bytearray([0x20, 0x00, 0x00, 0x00]))
1053+
await self._hue_light_cluster.multicolor(
1054+
data=bytearray([0x20, 0x00, 0x00, 0x00])
1055+
)
10511056
self._effect = EFFECT_OFF
10521057
else:
10531058
# Don't react on unknown effects, for example 'colorloop'

zha/zigbee/cluster_handlers/const.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
CLUSTER_HANDLER_ZONE: Final[str] = "ias_zone"
7777
ZONE: Final[str] = CLUSTER_HANDLER_ZONE
7878
CLUSTER_HANDLER_INOVELLI = "inovelli_vzm31sn_cluster"
79+
CLUSTER_HANDLER_PHILIPS_HUE_LIGHT: Final[str] = "philips_hue_light_cluster"
7980

8081
AQARA_OPPLE_CLUSTER: Final[int] = 0xFCC0
8182
IKEA_AIR_PURIFIER_CLUSTER: Final[int] = 0xFC7D

0 commit comments

Comments
 (0)