We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I think there's a bug when using negative tolerance.
if I put an element squarely in the centre of the screen and call:
$(#test).is(':in-viewport(-100)');
It will return false.
false
This is because the bottom is less than the settings.tolerance (which is set to the viewport height minus the offset).
bottom
settings.tolerance
isVisibleFlag = settings.tolerance ? top <= settings.tolerance && bottom >= settings.tolerance : bottom > 0 && top <= $viewportHeight
I believe that this should be bottom <= settings.tolerance.
bottom <= settings.tolerance
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I think there's a bug when using negative tolerance.
if I put an element squarely in the centre of the screen and call:
It will return
false
.This is because the
bottom
is less than thesettings.tolerance
(which is set to the viewport height minus the offset).I believe that this should be
bottom <= settings.tolerance
.The text was updated successfully, but these errors were encountered: