Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessControlImpl need to be a class instead object #4

Open
caobinzi opened this issue Dec 1, 2023 · 0 comments
Open

AccessControlImpl need to be a class instead object #4

caobinzi opened this issue Dec 1, 2023 · 0 comments

Comments

@caobinzi
Copy link
Collaborator

caobinzi commented Dec 1, 2023 •
edited
Loading

Change AccessControlImpl to

  • case class AccessControlImpl(provider:AccessControlProvider) to be more generic, and let user to be able to set its own access control implementations

https://github.com/zetaris/lightning-metastore/blob/master/spark/v3.3/spark-extensions/src/main/scala/com/zetaris/lightning/analysis/AccessControlImpl.scala#L45

This will make the class not dependent on LightningModel and make it decoupled from LightningModel , and it can have its own unit tests if possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caobinzi