Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mechanism to revoke withdraw and whitelist cap, and pause deposit #25

Merged
merged 8 commits into from
Feb 7, 2025
Merged

feat: mechanism to revoke withdraw and whitelist cap, and pause deposit #25

merged 8 commits into from
Feb 7, 2025

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Feb 5, 2025 •
edited
Loading

  • Use whitelistCap to allow whitelist (so it can be called by the TSS)
  • AdminCap allows to revoke previous withdraw and whitelist caps
  • Add deposit pausing mechanism
  • Add more unit tests

Closes #9

@lumtis lumtis marked this pull request as ready for review February 6, 2025 10:00
@lumtis lumtis requested a review from a team as a code owner February 6, 2025 10:00
@lumtis lumtis linked an issue Feb 6, 2025 that may be closed by this pull request
Implement unit tests for failure cases #10
Closed
@lumtis lumtis linked an issue Feb 6, 2025 that may be closed by this pull request
Add pausing mechanism #27
Closed
@lumtis lumtis changed the title feat: mechanism to revoke withdraw and whitelist cap feat: mechanism to revoke withdraw and whitelist cap, and pause deposit Feb 6, 2025
brewmaster012
brewmaster012 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit ef23e96 into main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lumtis @brewmaster012