feat(zetaclient): add dedicated restricted addresses config file #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
gartnera
changed the title
gartnera
commented
Feb 26, 2025
| @@ -77,7 +86,7 @@ func Start(_ *cobra.Command, _ []string) error { | |||
| return errors.Wrap(err, "unable to update app context") | |||
| } | |||
|
|
|||
| log.Info().Msgf("Config is updated from zetacore\n %s", cfg.StringMasked()) | |||
| log.Debug().Msgf("Config is updated from zetacore\n %s", cfg.StringMasked()) | |||
There was a problem hiding this comment.
Unrelated change but I don't think logging the whole config every start is great
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3600 +/- ##
===========================================
- Coverage 64.69% 64.54% -0.15%
===========================================
Files 466 466
Lines 32477 32549 +72
===========================================
Hits 21010 21010
- Misses 10512 10584 +72
Partials 955 955
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dedicated restricted addresses config file. Watch the file for changes and automatically reload it when it changes. This allows us to easily update the addresses in an automated sidecar process without having to restart zetaclient and increase error rates.
You can still use the
RestrictedAddressessection of the main config. The addresses from the new config will be merged with those addresses.