Skip to content

Commit 9ed0079

Browse files
committed
CI: Don't rebuild for electron
Use npm install --runtime=electron instead prebuild/prebuild#135
1 parent 4792b64 commit 9ed0079

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

.travis.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ matrix:
1414
- node_js: "6"
1515
env: DEPLOY="true"
1616
- node_js: "6"
17-
env: ELECTRON="1.1.3"
18-
- node_js: "6"
19-
env: ELECTRON="1.4.4" REBUILD="true"
17+
env: ELECTRON="1.4.10"
2018
- os: osx
2119
node_js: "6"
2220
env: DEPLOY="true"
@@ -31,9 +29,8 @@ before_install:
3129
- test "$(uname)" = "Darwin" || export CXX=g++-4.9 CC=gcc-4.9
3230

3331
install:
34-
- npm install
35-
- '[ -z "$ELECTRON" ] || npm install electron-prebuilt@${ELECTRON}'
36-
- '[ -z "$REBUILD" ] || ./node_modules/node-gyp/bin/node-gyp.js rebuild --runtime=electron --target=${ELECTRON} --disturl=https://atom.io/download/atom-shell --build-from-source'
32+
- '[ -z "$ELECTRON" ] || npm install electron@${ELECTRON}'
33+
- 'if [[ -z "$ELECTRON" ]]; then npm install; else npm install --runtime=electron --target=${ELECTRON} --disturl=https://atom.io/download/electron; fi'
3734

3835
script: if [[ -z "$ELECTRON" ]]; then travis_retry npm run coverage; else travis_retry npm run test:electron; fi
3936

appveyor.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ environment:
55
- nodejs_version: "4"
66
deploy: "true"
77
- nodejs_version: "6"
8-
electron: "1.4.4"
8+
electron: "1.4.10"
99

1010
platform:
1111
- x64
@@ -15,10 +15,8 @@ build: off
1515

1616
install:
1717
- ps: Install-Product node $env:nodejs_version $env:platform
18-
- npm install
19-
- IF DEFINED ELECTRON (npm install electron-prebuilt@%ELECTRON%)
20-
# We always need to rebuild for electron even for electron <= 1.1.3
21-
- IF DEFINED ELECTRON (node_modules\.bin\node-gyp rebuild --runtime=electron --target=%ELECTRON% --disturl=https://atom.io/download/atom-shell --build-from-source)
18+
- IF DEFINED ELECTRON (npm install electron@%ELECTRON%)
19+
- IF DEFINED ELECTRON (npm install --runtime=electron --target=%ELECTRON% --disturl=https://atom.io/download/electron) ELSE (npm install)
2220

2321

2422
test_script:

0 commit comments

Comments
 (0)