Skip to content

Commit 58f5e61

Browse files
committed
feat(debugger): use dap-js instead of legacy debug adapters
The debug adapters powering [`dap-node`][vscode-node-debug], [`dap-chrome`][vscode-chrome-debug], and [`dap-edge`][vscode-edge-debug2] have all been deprecated and unmaintained for a while in favour of [`vscode-js-debug`][vscode-js-debug]. `dap-mode` has [added support for `vscode-js-debug`][pr], via `dap-js`. [vscode-node-debug]: https://github.com/microsoft/vscode-node-debug [vscode-chrome-debug]: https://github.com/Microsoft/vscode-chrome-debug [vscode-edge-debug2]: https://github.com/microsoft/vscode-edge-debug2 [vscode-js-debug]: emacs-lsp/dap-mode#733 [pr]: emacs-lsp/dap-mode#369
1 parent 9620bb4 commit 58f5e61

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

modules/tools/debugger/config.el

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
((:lang rust +lsp) :after rustic-mode :require (dap-lldb dap-cpptools))
2828
((:lang javascript +lsp)
2929
:after (js2-mode typescript-mode)
30-
:require (dap-node dap-chrome dap-firefox ,@(if (featurep :system 'windows) '(dap-edge)))))
30+
:require (dap-js dap-firefox)))
3131
"TODO")
3232

3333

@@ -52,7 +52,7 @@
5252
:defer t
5353
:init (add-to-list '+debugger--realgud-alist
5454
'(realgud:trepan-ni :modes (javascript-mode js2-mode js3-mode)
55-
:package realgud-trepan-ni)))
55+
:package realgud-trepan-ni)))
5656

5757
;; Realgud doesn't generate its autoloads properly so we do it ourselves
5858
(dolist (debugger +debugger--realgud-alist)
@@ -157,4 +157,4 @@
157157
(use-package! dap-ui
158158
:when (and (modulep! +lsp) (not (modulep! :tools lsp +eglot)))
159159
:hook (dap-mode . dap-ui-mode)
160-
:hook (dap-ui-mode . dap-ui-controls-mode))
160+
:hook (dap-ui-mode . dap-auto-configure-mode))

0 commit comments

Comments
 (0)