[2.3.2] new()->many(2) creates single instance

[xdrew]

Hi! After an update from 2.3.1 some my tests began failing. The factory looks like:

final class OrderFactory extends PersistentProxyObjectFactory
{
    public function withProducts($count = 1): self
    {
        return $this->with(['orderProducts' => OrderProductFactory::new()->many($count)]);
    }
}

And calling this code:

        $user = UserFactory::createOne();
        $order = OrderFactory::new()->withUser($user)->withProducts(2)->create();

        $json = $this
            ->browser()
            ->actingAs($user->_real())
            ->get('/api/orders/' . $order->getUuid())
            ->assertStatus(200)
            ->dump()
            ->json();

shows:

...
{
    "orderProducts": [
        {
            "id": 129,
        }
    ],

On 2.3.1 it creates and shows 2. The bug also appears for 2.3.3 version

[nikophil]

Hello @xdrew

I cannot reproduce your problem.

Could you create a reproducer, or create a failing test case in Foundry's testsuite? You'll find a OneToMany in Category::$contact. You can add the test in EntityFactoryRelationshipTestCase

[xdrew]

Could you create a reproducer, or create a failing test case in Foundry's testsuite? You'll find a OneToMany in Category::$contact. You can add the test in EntityFactoryRelationshipTestCase

Ok, I'll take a look

[nikophil]

I'm closing this, since I was unable to reproduce, and the case is covered by tests:

foundry/tests/Integration/ORM/EntityRelationship/EntityFactoryRelationshipTestCase.php

Line 67 in 59d617c

public function one_to_many_with_factory_collection(): void

feel free to reopen it, with a reproducer project (or a failing test case in the tests)