Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit 6296d98

Browse files
committed
Merge pull request #130 from Koopzington/new-coding-standard
New coding standard
2 parents 304b5a7 + 2bdc94b commit 6296d98

File tree

120 files changed

+901
-1092
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+901
-1092
lines changed

.php_cs

Lines changed: 0 additions & 45 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,24 +77,24 @@ To do so:
7777

7878
## Running Coding Standards Checks
7979

80-
This component uses [php-cs-fixer](http://cs.sensiolabs.org/) for coding
80+
This component uses [phpcs](https://github.com/squizlabs/PHP_CodeSniffer) for coding
8181
standards checks, and provides configuration for our selected checks.
82-
`php-cs-fixer` is installed by default via Composer.
82+
`phpcs` is installed by default via Composer.
8383

8484
To run checks only:
8585

8686
```console
87-
$ ./vendor/bin/php-cs-fixer fix . -v --diff --dry-run --config-file=.php_cs
87+
$ composer cs-check
8888
```
8989

90-
To have `php-cs-fixer` attempt to fix problems for you, omit the `--dry-run`
91-
flag:
90+
`phpcs` also includes a tool for fixing most CS violations, `phpcbf`:
91+
9292

9393
```console
94-
$ ./vendor/bin/php-cs-fixer fix . -v --diff --config-file=.php_cs
94+
$ composer cs-fix
9595
```
9696

97-
If you allow php-cs-fixer to fix CS issues, please re-run the tests to ensure
97+
If you allow `phpcbf` to fix CS issues, please re-run the tests to ensure
9898
they pass, and make sure you add and commit the changes after verification.
9999

100100
## Recommended Workflow for Contributions

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
"zendframework/zend-validator": "^2.6",
3737
"zendframework/zend-view": "^2.6.2",
3838
"zendframework/zendservice-recaptcha": "*",
39-
"fabpot/php-cs-fixer": "1.7.*",
40-
"phpunit/phpunit": "^4.8"
39+
"phpunit/phpunit": "^4.8",
40+
"zendframework/zend-coding-standard": "~1.0.0"
4141
},
4242
"suggest": {
4343
"zendframework/zend-captcha": "^2.5.4, required for using CAPTCHA form elements",
@@ -73,10 +73,10 @@
7373
"@cs-check",
7474
"@test"
7575
],
76-
"upload-coverage": "coveralls -v",
77-
"cs-check": "php-cs-fixer --version && php-cs-fixer fix -v --diff --dry-run",
78-
"cs-fix": "php-cs-fixer fix -v",
79-
"test": "phpunit",
80-
"test-coverage": "phpunit --coverage-clover clover.xml"
76+
"cs-check": "phpcs",
77+
"cs-fix": "phpcbf",
78+
"test": "phpunit --colors=always",
79+
"test-coverage": "phpunit --colors=always --coverage-clover clover.xml",
80+
"upload-coverage": "coveralls -v"
8181
}
8282
}

0 commit comments

Comments
 (0)