Skip to content

Commit 7ad2d88

Browse files
RogersRogers
Rogers
authored and
Rogers
committed
* Avoid line continuation
* Fix typo and rename the method to build_errors
1 parent 16dbf15 commit 7ad2d88

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

lib/zendesk_apps_support/validations/requirements.rb

+5-7
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,20 @@ module Requirements
99
class << self
1010
def call(package)
1111
unless package.has_requirements?
12-
return [ValidationError.new(:missing_requirements)] \
13-
if package.manifest.requirements_only?
14-
12+
return [ValidationError.new(:missing_requirements)] if package.manifest.requirements_only?
13+
1514
return []
1615
end
1716

18-
return [ValidationError.new(:requirements_not_supported)] \
19-
unless supports_requirements(package)
17+
return [ValidationError.new(:requirements_not_supported)] unless supports_requirements(package)
2018

2119
begin
2220
requirements = package.requirements_json
2321
rescue ZendeskAppsSupport::Manifest::OverrideError => e
2422
return [ValidationError.new(:duplicate_requirements, duplicate_keys: e.key, count: 1)]
2523
end
2624

27-
erros(requirements)
25+
build_errors(requirements)
2826
rescue JSON::ParserError => e
2927
return [ValidationError.new(:requirements_not_json, errors: e)]
3028
end
@@ -175,7 +173,7 @@ def invalid_target_types(requirements)
175173
end
176174
end
177175

178-
def erros(requirements)
176+
def build_errors(requirements)
179177
[].tap do |errors|
180178
errors << invalid_requirements_types(requirements)
181179
errors << excessive_requirements(requirements)

0 commit comments

Comments
 (0)