Remove aws region validation (#38)

* Remove aws region validation

removed it, as it was causing issue whenever we add a new region

* fix test cases

* fix

Author: mshiwal

aws_region.go

@@ -32,7 +32,6 @@ var AWSRegions = []AWSRegion{
 
 var (
 	ErrAWSRegionEmptyString = errors.New("Region cannot be empty")
-	ErrAWSRegionInvalid     = errors.New("Region is invalid")
 )
 
 func (r *AWSRegion) UnmarshalText(data []byte) error {
@@ -46,12 +45,5 @@ func (r AWSRegion) Validate() error {
 		return ErrAWSRegionEmptyString
 	}
 
-	if r != AWS_REGION_US_EAST_1 && r != AWS_REGION_US_WEST_1 && r != AWS_REGION_US_WEST_2 && r != AWS_REGION_US_GOV_WEST_1 &&
-		r != AWS_REGION_EU_WEST_1 && r != AWS_REGION_EU_CENTRAL_1 &&
-		r != AWS_REGION_AP_SOUTHEAST_1 && r != AWS_REGION_AP_SOUTHEAST_2 && r != AWS_REGION_AP_NORTHEAST_1 &&
-		r != AWS_REGION_SA_EAST_1 {
-		return ErrAWSRegionInvalid
-	}
-
 	return nil
 }

aws_region_test.go

@@ -34,13 +34,6 @@ func (s *AWSRegionSuite) TestValidateErrorNoRegion() {
 	assert.Equal(s.T(), ErrAWSRegionEmptyString, err)
 }
 
-func (s *AWSRegionSuite) TestValidateErrorInvalidRegion() {
-	r := AWSRegion("invalidregion")
-	err := r.Validate()
-	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), ErrAWSRegionInvalid, err)
-}
-
 func (s *AWSRegionSuite) TestUnmarshalText() {
 	r := AWSRegion("")
 	d := []byte(AWS_REGION_US_EAST_1)
@@ -56,11 +49,3 @@ func (s *AWSRegionSuite) TestUnmarshalErrorNoRegion() {
 	assert.NotNil(s.T(), err)
 	assert.Equal(s.T(), ErrAWSRegionEmptyString, err)
 }
-
-func (s *AWSRegionSuite) TestUnmarshalErrorInvalidRegion() {
-	r := AWSRegion("")
-	d := []byte("invalidregion")
-	err := r.UnmarshalText(d)
-	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), ErrAWSRegionInvalid, err)
-}

remoteconfig_test.go

@@ -203,7 +203,7 @@ func (s *RemoteConfigSuite) TestValidateConfigWithReflectionErrorSQSQueueConfigV
 	}
 	err := validateConfigWithReflection(c)
 	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), errors.New("Sub Field of SQSQueue, failed to validate with error, Validater Field: Region, failed to validate with error, Region is invalid"), err)
+	assert.Equal(s.T(), errors.New("Sub Field of SQSQueue, failed to validate with error, Field: AWSAccountID, not set"), err)
 }
 
 func (s *RemoteConfigSuite) TestValidateConfigWithReflectionErrorDynamoDBTableConfigNotSet() {
@@ -292,7 +292,7 @@ func (s *RemoteConfigSuite) TestValidateConfigWithReflectionErrorDynamoDBClientC
 
 	err := validateConfigWithReflection(c)
 	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), errors.New("Sub Field of DynamoDBClient, failed to validate with error, Validater Field: Region, failed to validate with error, Region is invalid"), err)
+	assert.Equal(s.T(), errors.New("String Field: Str, contains an empty string"), err)
 }
 
 func (s *RemoteConfigSuite) TestValidateConfigWithReflectionErrorDynamoDBTableConfigValidate() {

s3_config_test.go

@@ -111,20 +111,6 @@ func (s *S3ConfigSuite) TestValidateErrorRegionNotSet() {
 	s.Equal(errors.New("Field: Region, not set"), err)
 }
 
-func (s *S3ConfigSuite) TestValidateErrorRegionInvalid() {
-	bucket := VALID_S3_CONFIG_BUCKET
-	region := AWSRegion("invalidregion")
-
-	c := &S3Config{
-		Bucket: &bucket,
-		Region: &region,
-	}
-
-	err := validateConfigWithReflection(c)
-	s.NotNil(err)
-	s.Equal(errors.New("Validater Field: Region, failed to validate with error, Region is invalid"), err)
-}
-
 func (s *S3ConfigSuite) TestGetEndpointNotSet() {
 	bucket := VALID_S3_CONFIG_BUCKET
 	region := VALID_S3_CONFIG_REGION

sqs_client_config_test.go

@@ -51,18 +51,6 @@ func (s *SQSClientConfigSuite) TestValidateWithEndpoint() {
 	assert.Nil(s.T(), err)
 }
 
-func (s *SQSClientConfigSuite) TestValidateErrorRegion() {
-	region := AWSRegion("invalidregion")
-
-	c := &SQSClientConfig{
-		Region: &region,
-	}
-
-	err := validateConfigWithReflection(c)
-	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), errors.New("Validater Field: Region, failed to validate with error, Region is invalid"), err)
-}
-
 func (s *SQSClientConfigSuite) TestValidateErrorEndpoint() {
 	region := VALID_SQS_CLIENT_REGION
 	endpoint := ""

sqs_queue_config_test.go

@@ -51,22 +51,6 @@ func (s *SQSQueueConfigSuite) TestValidate() {
 	assert.Nil(s.T(), err)
 }
 
-func (s *SQSQueueConfigSuite) TestValidateErrorRegion() {
-	region := AWSRegion("invalidregion")
-	awsAccountID := VALID_SQS_QUEUE_AWS_ACCOUNT_ID
-	queueName := VALID_SQS_QUEUE_QUEUE_NAME
-
-	c := &SQSQueueConfig{
-		Region:       &region,
-		AWSAccountID: &awsAccountID,
-		QueueName:    &queueName,
-	}
-
-	err := validateConfigWithReflection(c)
-	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), errors.New("Validater Field: Region, failed to validate with error, Region is invalid"), err)
-}
-
 func (s *SQSQueueConfigSuite) TestValidateErrorAWSAccountID() {
 	region := VALID_SQS_QUEUE_REGION
 	awsAccountID := ""

storage_config_test.go

@@ -52,19 +52,6 @@ func (s *StorageConfigSuite) TestValidateConfigWithReflectionErrorProvider() {
 	assert.Equal(s.T(), errors.New("Validater Field: StorageConfig, failed to validate with error, Invalid storage provider"), err)
 }
 
-func (s *StorageConfigSuite) TestValidateConfigWithReflectionErrorLocation() {
-	p := VALID_STORAGE_CONFIG_PROVIDER
-	l := (StorageLocation)("invalid_location")
-	c := &StorageConfig{
-		Provider: &p,
-		Location: &l,
-	}
-
-	err := validateConfigWithReflection(c)
-	assert.NotNil(s.T(), err)
-	assert.Equal(s.T(), errors.New("Validater Field: StorageConfig, failed to validate with error, Region is invalid"), err)
-}
-
 func (s *StorageConfigSuite) TestGetProvider() {
 	p := VALID_STORAGE_CONFIG_PROVIDER
 	c := &StorageConfig{