visual studio code show error

[tagplus5]

[js] Exported external package typings file '.../node_modules/json2csv/index.d.ts' is not a module. Please contact the package author to update the package definition.

[knownasilya]

Feel free to submit a PR, I don't use TS.

[mlegenhausen]

Using declare module seems to be deprecated: microsoft/TypeScript#2839

I changed the typescript definition to the following:

declare namespace json2csv {
  interface CSVCallback {
    (error: Error, csv: string): void;
  }

  export function json2csv(options: any, callback: CSVCallback): string;
}

export = json2csv.json2csv;

I will prepare a pull request and try to validate if this the current state of the are type definition format.

[mlegenhausen]

In which version will this fix be available?

[knownasilya]

It is now released as 3.4.1

[mlegenhausen]

@knownasilya thanks :)

[quantuminformation]

Has anyone been able to use this with TS? Would be great to add a section in the docs for ts for a minimal example.

[knownasilya]

Feel free to pioneer this, and I'll review your PR.

[quantuminformation]

I found a stopgap,but not using this repo, atm I'm snowed under with work