terminal: Fix escaping arguments when using CMD as the shell #39701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of caveats: - We should not auto-escape arguments with Alacritty's `escape_args` option if using CMD otherwise, the generated command will have way too many escaped characters for CMD to parse correctly. - When composing a full command for CMD, we need to put it in double quotes manually: `cmd /C "activate.bat& pwsh.exe -C do_something"` so that CMD executes the entire string as a sequence of commands. - CMD requires `&` as a chaining operator for commands (`;` for other shells).
cla-bot
bot
added
the
cla-signed
Veykril
reviewed
Oct 8, 2025
Comment on lines
+211
to
+213
| // We need to put the entire command in quotes since otherwise CMD tries to execute them | ||
| // as separate commands rather than chaining one after another. | ||
| arg = format!("\"{arg}\""); |
Member
There was a problem hiding this comment.
ShellBuilder itself is probably prone to doing this incorrectly as well then?
Member
Author
There was a problem hiding this comment.
That was a good catch - confirmed that ' does not work with CMD. I tweaked ShellBuilder to also use double quotes.
JosephTLyons
pushed a commit
that referenced
this pull request
Oct 8, 2025
A couple of caveats: - We should not auto-escape arguments with Alacritty's `escape_args` option if using CMD otherwise, the generated command will have way too many escaped characters for CMD to parse correctly. - When composing a full command for CMD, we need to put it in double quotes manually: `cmd /C "activate.bat& pwsh.exe -C do_something"` so that CMD executes the entire string as a sequence of commands. - CMD requires `&` as a chaining operator for commands (`;` for other shells). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Oct 11, 2025
…ustries#39701) A couple of caveats: - We should not auto-escape arguments with Alacritty's `escape_args` option if using CMD otherwise, the generated command will have way too many escaped characters for CMD to parse correctly. - When composing a full command for CMD, we need to put it in double quotes manually: `cmd /C "activate.bat& pwsh.exe -C do_something"` so that CMD executes the entire string as a sequence of commands. - CMD requires `&` as a chaining operator for commands (`;` for other shells). Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of caveats:
escape_argsoption if using CMD otherwise, the generated command will have way too many escaped characters for CMD to parse correctly.cmd /C "activate.bat& pwsh.exe -C do_something"so that CMD executes the entire string as a sequence of commands.&as a chaining operator for commands (;for other shells).Release Notes: