Syntax highlighting issue with POSIX bracket expressions in regexes

[callmesangio]

Hi, and thanks for this extension.

I just wanted to report that the syntax highlighting for regexes with POSIX bracket expressions seems a little bit off:

This is with Zed 0.217.3 and Ruby extension 0.16.2.

Thanks!

[vitallium]

Thanks for reporting! This looks like an issue with the tree-sitter grammar. I've created an issue in upstream and will push a fix for it later.

[callmesangio]

Awesome, thanks!

[vitallium]

I've opened a pull request with a fix: tree-sitter/tree-sitter-ruby#285

[vitallium]

Before	After

[vitallium]

Oh, wait. I think there is another issue with POSIX expressions.

[callmesangio]

Yes, I was reading everything and was about to ask. The POSIX expression should get both brackets highlighted, so this is probably something that goes beyond parsing of escape sequences.

[vitallium]

I think the provided regex is wrong: [[[:alpha:]]\d]+ The Ruby regexp engine is lenient and it allows such regexp but it's treated as [[:alpha:]]. This is a non-standard scenario, not sure if this is something that should be fixed in the regex tree-sitter grammar.

[callmesangio]

Apparently the two regexes behave differently though, I don't think they're equivalent:

irb(main):001> RUBY_VERSION
=> "3.4.8"
irb(main):002> /[[[:alpha:]]]+/.match "f1"
=> #<MatchData "f">
irb(main):003> /[[[:alpha:]]\d]+/.match "f1"
=> #<MatchData "f1">

irb(main):001> /\A[[[:alpha:]]]+\z/.match "f1"
=> nil
irb(main):002> /\A[[[:alpha:]]\d]+\z/.match "f1"
=> #<MatchData "f1">