-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using sphinx-immaterial #2894
Comments
Here is a sample: https://zarr--2899.org.readthedocs.build/en/2899/quickstart.html it's missing the announcement banner, it can be added though: https://jbms.github.io/sphinx-immaterial/customization.html#new-blocks |
Note that to take full advantage, you may want to use the python-apigen extension (replaces autosummary): https://jbms.github.io/sphinx-immaterial/apidoc/python/apigen.html |
There is also support for JSON schemas as a Sphinx domain, which may not be too useful for zarr-python but could be very useful for the zarr spec: https://google.github.io/tensorstore/driver/zarr3/index.html#json-driver/zarr3/Metadata |
I see that the API documentation is displaying with weird spacing: https://zarr--2899.org.readthedocs.build/en/2899/api/zarr/index.html Not sure if that is a bug in the theme, or caused by some custom css that you have. |
i think this looks really good |
Code blocks in API ref looks really weird. https://zarr--2899.org.readthedocs.build/en/2899/api/zarr/index.html |
Switching from using the numpydoc extension to using sphinx.ext.napoleon should fix at least some of the issues. |
I investigated this a bit more and identified a few bugs and limitations in the sphinx-immaterial theme. Those are now fixed, and I created a PR against the branch that @dikwickley created that makes this theme work much better: |
thank you @jbms for the changes! but the build failed due to many warnings (that are treated as errors) :( |
Well... I understand if other developers are reticent, but you could just switch to mkdocs-material. It doesn't look like there's that much prose documentation that you'd need to convert, and I expect the docstrings would continue to work without changes. I'm heavily biased because I love my mkdocs-based sites, and nowadays mkdocs has really excellent API documentation via mkdocstrings, but I figure that most projects that have been around for a while, like zarr, use sphinx because that was the only option when the project was created. But this really revolves around whether the developers here actually prefer RST vs Markdown. |
personally I would love to use mkdocs-material. And I would be surprised if there's anyone here who strongly prefers rst over markdown. |
@jbms maintains an excellent theme for sphinx that (IMO) looks much cleaner than our current theme. I would be interested in seeing what our docs page could look like with that theme.
The text was updated successfully, but these errors were encountered: