Skip to content

Commit 405b50a

Browse files
committed
chore(ci): fix cpu weekly benchmarks schedule groups handling
The steps responsible for setting the OP_FLAVOR and ALL_PRECISION variables were never executed due to usage of non-existing env variable. This causes OP_FLAVOR value to be null and thus would trigger error on benchmarks that doesn't handle unknown values for BENCH_OP_FLAVOR. Also fixes filename to parse for additional boolean benchmark.
1 parent 4dcc428 commit 405b50a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/benchmark_cpu_common.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ on:
2121
default: false
2222
additional_recipe: # Make recipes to run aside the benchmarks.
2323
type: string # Use comma separated values to generate an array
24-
additional_file_to_parse: # Make recipes aditional to run aside the benchamrks. Use comma separated values to generate an array
24+
additional_file_to_parse: # Other files to parse, located under tfhe-benchmark/ directory
2525
type: string # Use comma separated values to generate an array
2626
additional_results_type:
2727
type: string

.github/workflows/benchmark_cpu_weekly.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ jobs:
4646
echo "is_quarterly_bench=${{ github.event.schedule == '0 4 25 MAR,JUN,SEP,DEC *' }}" >> "${GITHUB_OUTPUT}"
4747
4848
- name: Weekly benchmarks
49-
if: env.WEEKLY_BENCH_GROUP_1 || env.WEEKLY_BENCH_GROUP_2
49+
if: steps.check_bench_group_1.outputs.is_weekly_bench_group_1 || steps.check_bench_group_2.outputs.is_weekly_bench_group_2
5050
run: |
5151
echo "OP_FLAVOR=[\"default\"]" >> "${GITHUB_ENV}"
5252
echo "ALL_PRECISIONS=false" >> "${GITHUB_ENV}"
5353
5454
- name: Quarterly benchmarks
55-
if: env.QUARTERLY_BENCH
55+
if: steps.check_quarterly_bench.outputs.is_quarterly_bench
5656
run: |
5757
echo "OP_FLAVOR=[\"default\", \"unchecked\"]" >> "${GITHUB_ENV}"
5858
echo "ALL_PRECISIONS=true" >> "${GITHUB_ENV}"
@@ -190,7 +190,7 @@ jobs:
190190
with:
191191
command: boolean
192192
additional_recipe: measure_boolean_key_sizes
193-
additional_file_to_parse: boolean_key_size.csv
193+
additional_file_to_parse: boolean_key_sizes.csv
194194
secrets:
195195
BOT_USERNAME: ${{ secrets.BOT_USERNAME }}
196196
SLACK_CHANNEL: ${{ secrets.SLACK_CHANNEL }}

0 commit comments

Comments
 (0)