Merge pull request #144 from BenoitAverty/status-of-code

feat(Status): Add a method to create a Status instance from an integer

Author: Willi Schönborn

jackson-datatype-problem/pom.xml

@@ -15,7 +15,7 @@
         <developerConnection>scm:git:[email protected]:zalando/problem.git</developerConnection>
     </scm>
     <properties>
-        <jackson.version>2.9.8</jackson.version>
+        <jackson.version>2.9.9</jackson.version>
     </properties>
     <dependencies>
         <dependency>

problem/pom.xml

@@ -43,6 +43,12 @@
             <version>${junit-jupiter.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-params</artifactId>
+            <version>${junit-jupiter.version}</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.hamcrest</groupId>
             <artifactId>java-hamcrest</artifactId>

problem/src/main/java/org/zalando/problem/Status.java

@@ -3,6 +3,7 @@
 import org.apiguardian.api.API;
 
 import javax.annotation.Nonnull;
+import java.util.Arrays;
 
 import static org.apiguardian.api.API.Status.MAINTAINED;
 
@@ -268,6 +269,20 @@ public enum Status implements StatusType {
         this.reason = reasonPhrase;
     }
 
+    /**
+     * Creates a Status instance from the given code.
+     *
+     * @param code the HTTP code as a number
+     * @return the correct enum value for this status code.
+     * @throws IllegalArgumentException if the given code does not correspond to a known HTTP status.
+     */
+    public static Status ofCode(int code) {
+        return Arrays.stream(Status.values())
+                .filter(status -> status.getStatusCode() == code)
+                .findFirst()
+                .orElseThrow(() -> new IllegalArgumentException("There is no known status for this code (" + code + ")."));
+    }
+
     /**
      * Get the associated status code.
      *

problem/src/test/java/org/zalando/problem/StatusTest.java

@@ -1,6 +1,9 @@
 package org.zalando.problem;
 
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
 
 import java.util.stream.Stream;
 
@@ -26,4 +29,25 @@ void shouldHaveMeaningfulToString() {
 
         assertThat(notFound.toString(), equalTo("404 Not Found"));
     }
+
+    @ParameterizedTest
+    @CsvSource({
+            "409, Conflict",
+            "404, Not Found",
+            "200, OK",
+            "500, Internal Server Error"
+    })
+    void shouldHaveCorrectValueFromCode(int code, String line) {
+        Status statusFromCode = Status.ofCode(code);
+
+        assertThat(statusFromCode.getStatusCode(), equalTo(code));
+        assertThat(statusFromCode.getReasonPhrase(), equalTo(line));
+    }
+
+    @Test
+    void shouldThrowOnNonExistingCode() {
+        Assertions.assertThrows(IllegalArgumentException.class, () -> {
+            Status.ofCode(111);
+        });
+    }
 }