find_chords_from_notes returns too few chords

[Moustov]

find_chords_from_notes(['A', 'C', 'E', 'G']) returns only 2 chords [<Chord: Am7>, <Chord: C6/A>]

• on my side, i have 26 (with some possible errors regarding names - some are also missing in this list such as E or G based chord names):
  [<Chord: Am7>, <Chord: Am7/9>, <Chord: Am7/11>, <Chord: Am7/13>, <Chord: Am/G>, <Chord: Am7/C>, <Chord: Am7/E>, <Chord: Am7/G>, <Chord: Am7/9/C>, <Chord: Am7/9/E>, <Chord: Am7/9/G>, <Chord: Am7/11/C>, <Chord: Am7/11/E>, <Chord: Am7/11/G>, <Chord: Am7/13/C>, <Chord: Am7/13/E>, <Chord: Am7/13/G>, <Chord: C6>, <Chord: C6/9>, <Chord: C/A>, <Chord: C6/A>, <Chord: C6/E>, <Chord: C6/G>, <Chord: C6/9/A>, <Chord: C6/9/E>, <Chord: C6/9/G>]
• the cause is due to notes_to_positions() which returns high positions (19, 21, up to 27 - as far as i can remember)
• this forces to extend the qualities possibilities such as (0, 3, 10, 19) which would lead to fundamental changes such as updating Quality.find_quality_from_components() with a %12 half tone-based check instead of list(q.components) == components (l.128)
• this leads to a possible change in the philosophy of the chord qualities since 19 sounds like 7 but this is not the exact same sound (1 octave difference)

What is your vision on this matter?

[Moustov]

seems related to #73 (comment)

[yuma-m]

Hi @Moustov, thank you for your contributions.
I have added a comment on #84 related to this. I think find_chords_from_notes should return simple variations of possible chords like now. There should be another function or argument to return all possible candidates if you believe it is useful for others.
https://github.com/yuma-m/pychord/pull/84/files#r1083399429

[Moustov]

Hi @yuma-m
beside my own need which i commented in https://github.com/yuma-m/pychord/pull/84/files#r1083399429, it appears that #73 (comment) deals with this issue...