Merge pull request #11 from Monchi/disable-completion-in-string-literal

Author: yukukotani

package-lock.json

@@ -18,6 +18,7 @@
   "homepage": "https://github.com/Monchi/typescript-plugin-namespace-import#readme",
   "dependencies": {
     "camelcase": "^6.2.0",
+    "tsutils": "^3.21.0",
     "typescript": "^4.3.5"
   },
   "devDependencies": {

package.json

@@ -1,3 +1,5 @@
+import ts, { SemanticClassificationFormat } from 'typescript/lib/tsserverlibrary';
+import * as tsutils from 'tsutils';
 import * as namespaceImportPlugin from './lib/import';
 
 declare global {
@@ -21,7 +23,14 @@ function init() {
     info.languageService.getCompletionsAtPosition = (fileName, position, options) => {
       log('getCompletionsAtPosition', { fileName, position, options });
       const original = getCompletionsAtPosition(fileName, position, options);
-      if (original == null || options?.triggerCharacter != null) {
+      if (
+        original == null ||
+        options?.triggerCharacter != null ||
+        !namespaceImportPlugin.isAutoCompletablePosition(
+          info.languageService.getProgram()?.getSourceFile(fileName),
+          position,
+        )
+      ) {
         return original;
       }
 

src/index.ts

@@ -1,6 +1,7 @@
 import ts, { CodeFixAction, ScriptElementKind } from 'typescript/lib/tsserverlibrary';
 import * as path from 'path';
 import camelCase from 'camelcase';
+import * as tsutils from 'tsutils';
 
 export type PluginOptions = {
   paths: readonly string[];
@@ -44,6 +45,14 @@ export function filterNamedImportEntries(
   });
 }
 
+export function isAutoCompletablePosition(sourceFile: ts.SourceFile | undefined, position: number): boolean {
+  if (!sourceFile) {
+    return false;
+  }
+  const token = tsutils.getTokenAtPosition(sourceFile!, position)?.kind ?? ts.SyntaxKind.Unknown;
+  return token !== ts.SyntaxKind.StringLiteral;
+}
+
 export function getCompletionEntryDetails(
   name: string,
   selfPath: string,