New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: descriptions (for types and fields) #55

Open

mbrowne opened this issue Sep 1, 2022 · 1 comment

mbrowne commented Sep 1, 2022

It would be great if this library provided a way to specify descriptions in protobuf that get included when generating the GraphQL schema:

https://spec.graphql.org/June2018/#sec-Descriptions

Owner

ysugimoto commented Sep 8, 2022 •

edited

Loading

Thanks for the issue, Now we don't support to generate GraphQL schema (FYI: I'm using get-graphql-schema https://github.com/prisma-labs/get-graphql-schema to generate schema for actual service).

BYW, how can we support for thiis? the generated execution code has a description that comes from protobuf field comment https://github.com/ysugimoto/grpc-graphql-gateway/blob/master/protoc-gen-graphql/template.go#L65

If you have any opinion, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment