-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always happen nil exception when exit after I enable metadata plugin #415
Comments
And my theme setting don't work yet. I don't know whether it is a bug. |
Needs investigation. Need to investigate metadata plugin in windows |
Able to reproduce.
|
Just create any file with .dat extension, and you will see crash while you try to see that file's metadata |
If exiftool is not there, it shouldn't crash at least. |
Same crash in linux too, when exiftool is not found
|
Verfied that crash doesn't happens after the fix. |
@Zim-Inn Thanks for the bug report. This has been fixed. Can you do a local build spf from the main branch and see if the issue if fixed for you ? |
@Zim-Inn Closing this. Please feel free to reopen if you still face the issue. |
Describe the bug
As the head says, when I disable the metadata plugin, the exception disappear.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Caught panic:
runtime error: invalid memory address or nil pointer dereference
Restoring terminal...
goroutine 1 [running]:
runtime/debug.Stack()
/usr/lib/golang/src/runtime/debug/stack.go:24 +0x5e
runtime/debug.PrintStack()
/usr/lib/golang/src/runtime/debug/stack.go:16 +0x13
github.com/charmbracelet/bubbletea.(*Program).Run.func1()
/home/yorukot/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:519 +0x91
panic({0x142e360?, 0x1ea78e0?})
/usr/lib/golang/src/runtime/panic.go:770 +0x132
github.com/barasher/go-exiftool.(*Exiftool).Close(0x0)
/home/yorukot/go/pkg/mod/github.com/barasher/[email protected]/exiftool.go:99 +0x41
github.com/yorukot/superfile/src/internal.model.quitSuperfile({{{0xc0003b4008, 0x1, 0x1}, 0x31, 0x0, 0x2, {0x1, 0x2f}}, {{0xc000146e00, 0xa, ...}, ...}, ...})
/home/yorukot/Documents/code/superfile/src/internal/model.go:358 +0x2e
github.com/yorukot/superfile/src/internal.model.handleKeyInput({{{0xc0003b4008, 0x1, 0x1}, 0x31, 0x0, 0x2, {0x1, 0x2f}}, {{0xc000146e00, 0xa, ...}, ...}, ...}, ...)
/home/yorukot/Documents/code/superfile/src/internal/model.go:190 +0x8d9
github.com/yorukot/superfile/src/internal.model.Update({{{0xc0003b4008, 0x1, 0x1}, 0x31, 0x0, 0x2, {0x1, 0x2f}}, {{0xc000146e00, 0xa, ...}, ...}, ...}, ...)
/home/yorukot/Documents/code/superfile/src/internal/model.go:58 +0x37c
github.com/charmbracelet/bubbletea.(*Program).eventLoop(0xc000612120, {0x18d9450?, 0xc0003b6a88?}, 0xc0000961e0)
/home/yorukot/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:452 +0x7f0
github.com/charmbracelet/bubbletea.(*Program).Run(0xc000612120)
/home/yorukot/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:593 +0xa52
github.com/yorukot/superfile/src/cmd.Run.func2(0xc0003b2880)
/home/yorukot/Documents/code/superfile/src/cmd/main.go:70 +0x179
github.com/urfave/cli/v2.(*Command).Run(0xc00017e580, 0xc0003b2880, {0xc000034090, 0x1, 0x1})
/home/yorukot/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:276 +0x97d
github.com/urfave/cli/v2.(*App).RunContext(0xc000146400, {0x18da010, 0x1f6cbe0}, {0xc000034090, 0x1, 0x1})
/home/yorukot/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:333 +0x5a5
github.com/urfave/cli/v2.(*App).Run(...)
/home/yorukot/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:307
github.com/yorukot/superfile/src/cmd.Run({0xc000076000?})
/home/yorukot/Documents/code/superfile/src/cmd/main.go:79 +0x2c6
main.main()
/home/yorukot/Documents/code/superfile/main.go:15 +0x1a
Screenshots
If applicable, add screenshots to help explain your problem.
System information (please complete the following information):
The text was updated successfully, but these errors were encountered: