Skip to content

Commit 7278083

Browse files
authored
Misc: improve (#94)
- ignore useless files for archives - ignore phpcs warning on scrutinizer - improve abstract kernel
1 parent 929e65a commit 7278083

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

.gitattributes

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
/.gitignore export-ignore
55
/.scrutinizer.yml export-ignore
66
/.travis.yml export-ignore
7+
/.editorconfig export-ignore
8+
/codecov.yml export-ignore
9+
/.remarkrc export-ignore
10+
/.remarkignore export-ignore
711
/behat.yml export-ignore
812
/phpunit.xml.dist export-ignore
913
/phpcs.xml.dist export-ignore

.scrutinizer.yml

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ build:
4444
COMPOSER_OPTIONS: '--optimize-autoloader'
4545
COVERAGE_OUTPUT_STYLE: 'clover'
4646
COVERAGE_CLOVER_FILE_PATH: 'build/coverage/clover.xml'
47+
PHPCS_DISABLE_WARNING: 'true'
4748
php:
4849
version: "8.2"
4950
ini:

features/demo_app/src/AbstractKernel.php

+6-2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,11 @@ public function getProjectDir(): string
5757
return realpath(__DIR__.'/../');
5858
}
5959

60+
public function getConfigDir(): string
61+
{
62+
return $this->getProjectDir().'/'.$this->getConfigDirectoryName();
63+
}
64+
6065
/**
6166
* @param RouteCollectionBuilder|RoutingConfigurator $routes
6267
*/
@@ -69,7 +74,7 @@ protected function configureRoutes($routes)
6974
$routes->import($confDir . '/routes' . self::CONFIG_EXTS, '/', 'glob');
7075
}
7176
}
72-
77+
7378
/**
7479
* {@inheritdoc}
7580
*/
@@ -93,5 +98,4 @@ protected function getContainerClass(): string
9398
}
9499

95100
abstract public function getConfigDirectoryName() : string;
96-
abstract public function getConfigDir(): string;
97101
}

features/demo_app/src/DefaultKernel.php

-5
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,4 @@ public function getConfigDirectoryName() : string
1010
{
1111
return 'default_config';
1212
}
13-
14-
public function getConfigDir(): string
15-
{
16-
return $this->getProjectDir().'/'.$this->getConfigDirectoryName();
17-
}
1813
}

0 commit comments

Comments
 (0)