[Security] Remove annoying deprecation in UsageTrackingTokenStorage

Author: chalasr

UPGRADE-5.3.md

@@ -106,9 +106,6 @@ Routing
 Security
 --------
 
- * Deprecate using `UsageTrackingTokenStorage` with tracking enabled without a main request. Use the untracked token
-   storage (service ID: `security.untracked_token_storage`) instead, or disable usage tracking
-   completely using `UsageTrackingTokenStorage::disableUsageTracking()`.
  * [BC BREAK] Remove method `checkIfCompletelyResolved()` from `PassportInterface`, checking that passport badges are
    resolved is up to `AuthenticatorManager`
  * Deprecate class `User`, use `InMemoryUser` or your own implementation instead.

src/Symfony/Component/Security/CHANGELOG.md

@@ -38,7 +38,6 @@ The CHANGELOG for version 5.4 and newer can be found in the security sub-package
  * Add `LegacyPasswordAuthenticatedUserInterface` for user classes that use user-provided salts in addition to passwords
  * Deprecate all classes in the `Core\Encoder\`  sub-namespace, use the `PasswordHasher` component instead
  * Deprecate the `SessionInterface $session` constructor argument of `SessionTokenStorage`, inject a `\Symfony\Component\HttpFoundation\RequestStack $requestStack` instead
- * Deprecate using `UsageTrackingTokenStorage` without a main request
  * Deprecate the `session` service provided by the ServiceLocator injected in `UsageTrackingTokenStorage`, provide a `request_stack` service instead
  * Deprecate using `SessionTokenStorage` outside a request context, it will throw a `SessionNotFoundException` in Symfony 6.0
  * Randomize CSRF tokens to harden BREACH attacks

src/Symfony/Component/Security/Core/Authentication/Token/Storage/UsageTrackingTokenStorage.php

@@ -101,8 +101,6 @@ private function shouldTrackUsage(): bool
         }
 
         if (!$this->container->get('request_stack')->getMainRequest()) {
-            trigger_deprecation('symfony/security-core', '5.3', 'Using "%s" (service ID: "security.token_storage") outside the request-response cycle is deprecated, use the "%s" class (service ID: "security.untracked_token_storage") instead or disable usage tracking using "disableUsageTracking()".', __CLASS__, TokenStorage::class);
-
             return false;
         }
 

src/Symfony/Component/Security/Core/Tests/Authentication/Token/Storage/UsageTrackingTokenStorageTest.php

@@ -13,7 +13,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerInterface;
-use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpFoundation\Session\SessionInterface;
@@ -24,8 +23,6 @@
 
 class UsageTrackingTokenStorageTest extends TestCase
 {
-    use ExpectDeprecationTrait;
-
     public function testGetSetToken()
     {
         $sessionAccess = 0;
@@ -69,9 +66,6 @@ public function testGetSetToken()
         $this->assertSame(1, $sessionAccess);
     }
 
-    /**
-     * @group legacy
-     */
     public function testWithoutMainRequest()
     {
         $locator = new class(['request_stack' => function () {
@@ -83,7 +77,6 @@ public function testWithoutMainRequest()
         $trackingStorage = new UsageTrackingTokenStorage($tokenStorage, $locator);
         $trackingStorage->enableUsageTracking();
 
-        $this->expectDeprecation('Since symfony/security-core 5.3: Using "%s" (service ID: "security.token_storage") outside the request-response cycle is deprecated, use the "%s" class (service ID: "security.untracked_token_storage") instead or disable usage tracking using "disableUsageTracking()".');
-        $trackingStorage->getToken();
+        $this->assertNull($trackingStorage->getToken());
     }
 }