FormatterNumberTest::testIntlAsScientific fails on GitLab

[schmunk42]

What steps will reproduce the problem?

See tests here: https://gitlab.com/yiisoft/yii2/-/jobs/368388365

What is the expected result?

No failure or error.

What do you get instead?

There was 1 failure:
573 1) yiiunit\framework\i18n\FormatterNumberTest::testIntlAsScientific
574 Failed asserting that two strings are identical.
575 --- Expected
576 +++ Actual
577 @@ @@
578 -8.76543210987654E16
579 +8.765432109876544E16
580 /project/tests/framework/i18n/FormatterNumberTest.php:531
581 /project/vendor/phpunit/phpunit/phpunit:52

Additional info

Q	A
Yii version	master
PHP version	7.1.33
Operating system	Debian (Docker)

Looks like there's one more digit now?!
Test fails since https://gitlab.com/yiisoft/yii2/commit/c1e9739ed232e207ff6920e90b7351b2b19f69d0

Pipelines: https://gitlab.com/yiisoft/yii2/pipelines

[schmunk42]

Just noticed: Test worked on PHP 7.1.26

[samdark]

So is there a change between that and PHP 7.1.33 that causes one extra digit to appear?

[bizley]

Has precision setting been changed in php.ini?

[schmunk42]

I triggered tests for all versions in question at https://gitlab.com/yiisoft/yii2-docker/pipelines

I have not changed anything in our files.

[schmunk42]

Tests fail for 7.1.30

PHP Changelog says:

Version 7.1.30
30 May 2019
EXIF:
Fixed bug #77988 (heap-buffer-overflow on php_jpg_get16) (CVE-2019-11040).
GD:
Fixed bug #77973 (Uninitialized read in gdImageCreateFromXbm) (CVE-2019-11038).
Iconv:
Fixed bug #78069 (Out-of-bounds read in iconv.c:_php_iconv_mime_decode() due to integer overflow) (CVE-2019-11039).
SQLite:
Fixed bug #77967 (Bypassing open_basedir restrictions via file uris).

[schmunk42]

Debian version has been changed:

> docker run --rm php:7.1.30-apache cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"



> docker run --rm php:7.1.29-apache cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

and likely some system-lib. Which one would be responsible for that?

[samdark]

No idea :(

[bizley]

Most likely precision setting has been changed. Maybe we should adjust tests to not rely on OS default settings.

[schmunk42]

It's the same...

> docker run --rm php:7.1.29-apache php -i | grep precision
precision => 14 => 14
serialize_precision => -1 => -1

> docker run --rm php:7.1.30-apache php -i | grep precision
precision => 14 => 14
serialize_precision => -1 => -1

[alex-code]

I don't think the precision setting of PHP is used by NumberFormatter.

[diego-mathis]

I would try:

'components' => [
 'formatter' => [
   'numberFormatterOptions'=>[
	\NumberFormatter::MIN_FRACTION_DIGITS => 0,
	\NumberFormatter::MAX_FRACTION_DIGITS => 14
   ]

Its rather strange

[bizley]

So... ICU version changed?

[schmunk42]

Diff between ini .29 and .30

> diff ini-29 ini-30 --color

2c2
< PHP Version => 7.1.29
---
> PHP Version => 7.1.30


4,5c4,5
< System => Linux 3b72a58a22bc 5.4.1-arch1-1 #1 SMP PREEMPT Fri, 29 Nov 2019 13:37:24 +0000 x86_64
< Build Date => May  8 2019 03:29:15
---
> System => Linux 1c8166c72bc8 5.4.1-arch1-1 #1 SMP PREEMPT Fri, 29 Nov 2019 13:37:24 +0000 x86_64
> Build Date => Jul 13 2019 00:26:16


< cURL Information => 7.52.1
< Age => 3
---
> cURL Information => 7.64.0
> Age => 4


164,166c164,166
< SSL Version => OpenSSL/1.0.2r
< ZLib Version => 1.2.8
< libSSH Version => libssh2/1.7.0
---
> SSL Version => OpenSSL/1.1.1c
> ZLib Version => 1.2.11
> libSSH Version => libssh2/1.8.0


226c226
< iconv library version => 2.24
---
> iconv library version => 2.28


455,456c455,456
< OpenSSL Library Version => OpenSSL 1.1.0j  20 Nov 2018
< OpenSSL Header Version => OpenSSL 1.1.0j  20 Nov 2018
---
> OpenSSL Library Version => OpenSSL 1.1.1c  28 May 2019
> OpenSSL Header Version => OpenSSL 1.1.1c  28 May 2019


576c576
< SQLite3 module version => 7.1.29
---
> SQLite3 module version => 7.1.30


626,627c626,627
< Compiled Version => 1.2.8
< Linked Version => 1.2.8
---
> Compiled Version => 1.2.11
> Linked Version => 1.2.11

How do I get ICU versions?

[diego-mathis]

Seems to me like a bug in Yii.
Php default is precision 14, but if intl is used - there is no default set. At least I cannot see any here:
https://www.php.net/manual/en/class.numberformatter.php

Maybe would be good to set defaults.

The info at the function asScientific - its not prominent enough.

* If not given, the number of digits depends in the input value and is determined based on
     * `NumberFormatter::MIN_FRACTION_DIGITS` and `NumberFormatter::MAX_FRACTION_DIGITS`, which can be configured
     * using [[$numberFormatterOptions]].
     * If the [PHP intl extension](https://secure.php.net/manual/en/book.intl.php) is not available, the default value depends on your PHP configuration.
     * If you want consistent behavior between environments where intl is available and not, you should explicitly
     * specify a value here.