Improve

Author: Tigrov

src/Column/BooleanColumn.php

@@ -35,6 +35,6 @@ public function phpTypecast(mixed $value): bool|null
             return null;
         }
 
-        return (bool) $value;
+        return $value && $value !== "\0";
     }
 }

tests/ColumnTest.php

@@ -5,10 +5,12 @@
 namespace Yiisoft\Db\Oracle\Tests;
 
 use PDO;
+use PHPUnit\Framework\Attributes\DataProviderExternal;
 use Yiisoft\Db\Command\Param;
 use Yiisoft\Db\Expression\Expression;
 use Yiisoft\Db\Oracle\Column\BinaryColumn;
 use Yiisoft\Db\Oracle\Column\JsonColumn;
+use Yiisoft\Db\Oracle\Tests\Provider\ColumnProvider;
 use Yiisoft\Db\Oracle\Tests\Support\TestTrait;
 use Yiisoft\Db\Query\Query;
 use Yiisoft\Db\Schema\Column\ColumnInterface;
@@ -106,12 +108,18 @@ public function testPredefinedType(string $className, string $type, string $phpT
         parent::testPredefinedType($className, $type, $phpType);
     }
 
-    /** @dataProvider \Yiisoft\Db\Oracle\Tests\Provider\ColumnProvider::dbTypecastColumns */
+    #[DataProviderExternal(ColumnProvider::class, 'dbTypecastColumns')]
     public function testDbTypecastColumns(ColumnInterface $column, array $values): void
     {
         parent::testDbTypecastColumns($column, $values);
     }
 
+    #[DataProviderExternal(ColumnProvider::class, 'phpTypecastColumns')]
+    public function testPhpTypecastColumns(ColumnInterface $column, array $values): void
+    {
+        parent::testPhpTypecastColumns($column, $values);
+    }
+
     public function testBinaryColumn(): void
     {
         $binaryCol = new BinaryColumn();

tests/Provider/ColumnProvider.php

@@ -45,4 +45,14 @@ public static function dbTypecastColumns(): array
 
         return $values;
     }
+
+    public static function phpTypecastColumns(): array
+    {
+        $values = parent::phpTypecastColumns();
+        $values['binary'][0] = new BinaryColumn();
+        $values['boolean'][0] = new BooleanColumn();
+        $values['json'][0] = new JsonColumn();
+
+        return $values;
+    }
 }