Skip to content

Commit b460b69

Browse files
authored
Merge pull request #150 from DavidVujic/md-files
Add: Changelog and Contributing info
2 parents 27e2c01 + 95639d3 commit b460b69

File tree

4 files changed

+38
-3
lines changed

4 files changed

+38
-3
lines changed

CHANGELOG.md

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
#### v 4.0.1 (2019-03-10)
2+
* Added docs: changelog, contributing to the project, fixed typos and missing info in the readme file.
3+
4+
#### v 4.0.0 (2019-03-02)
5+
* Added Windows support! A long awaited issue finally solved.
6+
* __BREAKING__: dropped support for Node.js versions oldder than version 8.
7+
* `node-zookeeper` now uses __SemVer__ for versioning.
8+
9+
Read details about the release here: [Windows support](https://github.com/yfinkelstein/node-zookeeper/pull/145)
10+
11+
#### v 3.4.9-4 (2019-01-16)
12+
* Fixed npm install fails when using Node version 10.
13+
14+
Details about the release here: [Node.js 10 support](https://github.com/yfinkelstein/node-zookeeper/pull/142)

CONTRIBUTING.md

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Contributing to the development of node-zookeeper
2+
3+
Fork this repo, write code and send a pull request. Easy!
4+
5+
### Guidelines
6+
* Create a branch for the feature you are about to write.
7+
* If possible, isolate the changes in the branch to the feature only. Merges will be easier if general refactorings, that are not specific to the feature, are made in separate branches.
8+
* If possible, avoid general dependency updates in the feature branch.
9+
* If possible, send pull requests early. Don't wait too long, even if the feature is not completely done. The new code can very likely be merged without causing any problems (if the code changes are not of type breaking features). Think of it as "silent releases".
10+
* If you think it is relevant and add value: write unit test(s). Use the`tape` unit test library. They could also be valuable as description of features.

README.md

+13-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
11
# Overview
22

3-
node-zookeeper - A Node.js client for Apache Zookeeper.
3+
_node-zookeeper - A Node.js client for Apache Zookeeper._
44

5-
This module is implemented on top of the ZooKeeper C API; consult the [ZK Reference](http://zookeeper.apache.org/doc/r3.4.0/index.html) for further details on behavior.
5+
This module is implemented on top of the ZooKeeper C API; consult the [ZK Reference](http://zookeeper.apache.org/doc/r3.4.13/index.html) for further details on behavior.
6+
7+
__Latest changes__ are described in the [changelog](./CHANGELOG.md)
8+
9+
## Installation
10+
(note the name `zookeeper` in lowercase)
11+
```bash
12+
npm install zookeeper
13+
```
614

715
# Example
816

@@ -286,6 +294,9 @@ DDOPSON-2011-11-30 - are these issues still relevant? unknown.
286294
- Any established watches may/will be fired once each when/if your client is expired by the ZK server, the input arguments are observed to be: type=-1, state=1, path="". Care should be taken to handle this differently than a "real" watch event if that matters to your application.
287295
- Otherwise, it just works!
288296

297+
# Contribute to the project
298+
Check out the issues tab and grab one! Read the [contributing](./CONTRIBUTING.md) document.
299+
289300
# See Also
290301

291302
- [http://zookeeper.apache.org/releases.html](http://zookeeper.apache.org/releases.html)

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "zookeeper",
33
"description": "apache zookeeper client (zookeeper async API >= 3.4.0)",
4-
"version": "4.0.0",
4+
"version": "4.0.1",
55
"author": "Yuri Finkelstein <[email protected]>",
66
"license": "MIT",
77
"contributors": [

0 commit comments

Comments
 (0)