Merge pull request #230 from wareczek/expected-3-arguments

fix bug "expected 3 arguments"

Author: DavidVujic

README.md

@@ -132,7 +132,7 @@ Check out the code in the [examples](./examples) folder: master,workers, tasks a
   * (note the trailing `_`)
 * `a_set_acl(path, version, acl, void_cb)`
 * `a_get_acl(path, acl_cb)`
-* `add_auth(scheme, auth)`
+* `add_auth(scheme, auth, void_cb)`
 
 *The watcher methods are forward-looking subscriptions that can recieve multiple callbacks whenever a matching event occurs.*
 

lib/zookeeper.js

@@ -328,11 +328,12 @@ class ZooKeeper extends EventEmitter {
     /**
      * @param scheme {string}
      * @param auth {string}
+     * @param voidCb {voidCb}
      * @returns {*}
      */
-    add_auth(scheme, auth) {
-        this.log(`Calling add_auth with ${util.inspect([scheme, auth])}`);
-        return this.native.add_auth(scheme, auth);
+    add_auth(scheme, auth, voidCb) {
+        this.log(`Calling add_auth with ${util.inspect([scheme, auth, voidCb])}`);
+        return this.native.add_auth(scheme, auth, voidCb);
     }
 
     /**

package.json

@@ -51,9 +51,10 @@
         "build-components": "node-gyp configure build --directory=tests/components",
         "install": "node ./scripts/prepublish.js && npm run build",
         "lint": "eslint .",
-        "test": "npm run lint && tape ./tests/unit/**/*.js | tap-spec",
+        "test": "npm run lint && npm run test-unit",
         "test-components": "npm run build-components && tape ./tests/components/**/*.js | tap-spec",
-        "test-integration": "node ./tests/integration/index"
+        "test-integration": "node ./tests/integration/index",
+        "test-unit": "tape ./tests/unit/**/*.js | tap-spec"
     },
     "engines": {
         "node": ">=8.9.4"

tests/unit/zookeeper/nativeobjecttest.js

@@ -57,3 +57,13 @@ test('native object emits close and pass an instance of the current ZooKeeper',
 
     zk.native.emit('close', 1, 2, 3);
 });
+
+test('native zookeeper add_auth', (t) => {
+    t.plan(3);
+
+    const zk = new ZooKeeper({});
+
+    t.throws(() => zk.native.add_auth('digest'), 'expected 3 arguments');
+    t.throws(() => zk.native.add_auth('digest', 'user:'), 'expected 3 arguments');
+    t.doesNotThrow(() => zk.native.add_auth('digest', 'user:', () => {}), 'expected 3 arguments');
+});