Skip to content

Commit 5f2e7c9

Browse files
authored
Merge pull request #242 from DavidVujic/bump-deps
Update dependencies causing audit warnings on install
2 parents 8693814 + ddd06e6 commit 5f2e7c9

File tree

7 files changed

+21
-22
lines changed

7 files changed

+21
-22
lines changed

examples/index.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ const { addTask } = require('./addtask.js');
77
const logger = require('./logger.js');
88
const notifier = require('./notifier.js');
99

10-
notifier.on('connect', message => logger.log('connect', message));
11-
notifier.on('createNode', message => logger.log('createNode', message));
12-
notifier.on('addTask', message => logger.log('addTask', message));
13-
notifier.on('close', message => logger.log('close', message));
10+
notifier.on('connect', (message) => logger.log('connect', message));
11+
notifier.on('createNode', (message) => logger.log('createNode', message));
12+
notifier.on('addTask', (message) => logger.log('addTask', message));
13+
notifier.on('close', (message) => logger.log('close', message));
1414

1515
notifier.on('onChildren', (children) => {
1616
children.forEach((child) => {

lib/constants.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const NativeZk = require('./../build/zookeeper.node').ZooKeeper;
1+
const NativeZk = require('../build/zookeeper.node').ZooKeeper;
22

33
/** @returns {number} 1 */
44
module.exports.ZOO_PERM_READ = NativeZk.ZOO_PERM_READ;

lib/promise.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,23 @@ class ZkPromise extends Promise {
1212
*/
1313
get(propertyName) {
1414
deprecationLog(ZkPromise.name, 'get');
15-
return this.then(object => object[propertyName]);
15+
return this.then((object) => object[propertyName]);
1616
}
1717

1818
/**
1919
* @deprecated
2020
*/
2121
put(propertyName, value) {
2222
deprecationLog(ZkPromise.name, 'put');
23-
return this.then(object => object[propertyName] = value);
23+
return this.then((object) => object[propertyName] = value);
2424
}
2525

2626
/**
2727
* @deprecated
2828
*/
2929
call(functionName, ...args) {
3030
deprecationLog(ZkPromise.name, 'call');
31-
return this.then(object => object[functionName](...args));
31+
return this.then((object) => object[functionName](...args));
3232
}
3333

3434
/**

lib/zookeeper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const _ = require('lodash');
66
const { normalize } = require('path');
77
const util = require('util');
88

9-
const NativeZk = require('./../build/zookeeper.node').ZooKeeper;
9+
const NativeZk = require('../build/zookeeper.node').ZooKeeper;
1010

1111
const Async = {
1212
apply,

package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -27,22 +27,22 @@
2727
"client"
2828
],
2929
"dependencies": {
30-
"async": "2.6.x",
30+
"async": "3.2.x",
3131
"decompress": "4.2.x",
3232
"decompress-targz": "4.1.x",
3333
"lodash": "4.x",
3434
"nan": "2.x",
3535
"shelljs": "0.8.x"
3636
},
3737
"devDependencies": {
38-
"eslint": "5.x",
39-
"eslint-config-airbnb-base": "13.x",
38+
"eslint": "7.x",
39+
"eslint-config-airbnb-base": "14.x",
4040
"eslint-plugin-import": "2.x",
41-
"log4js": "4.x",
41+
"log4js": "6.x",
4242
"proxyquire": "2.x",
43-
"sinon": "7.x",
43+
"sinon": "9.x",
4444
"tap-spec": "5.x",
45-
"tape": "4.x",
45+
"tape": "5.x",
4646
"webworker": "0.x"
4747
},
4848
"main": "lib/index",

tests/unit/util/promisetest.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ test('ZkPromise call', (t) => {
4242
test('ZkPromise addCallback', (t) => {
4343
t.plan(3);
4444

45-
const callback = sinon.stub().callsFake(value => value * 2);
45+
const callback = sinon.stub().callsFake((value) => value * 2);
4646
const promise = ZkPromise.resolve(10);
4747

4848
promise.addCallback(callback).then((actual) => {
@@ -55,7 +55,7 @@ test('ZkPromise addCallback', (t) => {
5555
test('ZkPromise addErrback', (t) => {
5656
t.plan(3);
5757

58-
const callback = sinon.stub().callsFake(value => value * 2);
58+
const callback = sinon.stub().callsFake((value) => value * 2);
5959
const promise = ZkPromise.reject(10);
6060

6161
promise.addErrback(callback).then((actual) => {
@@ -68,12 +68,12 @@ test('ZkPromise addErrback', (t) => {
6868
test('ZkPromise addBoth', (t) => {
6969
t.plan(7);
7070

71-
const callback = sinon.stub().callsFake(value => value * 2);
71+
const callback = sinon.stub().callsFake((value) => value * 2);
7272
const errback = sinon.stub().callsFake(() => {
7373
throw new Error('errback!');
7474
});
7575
// eslint-disable-next-line max-len
76-
const promise = succeeds => new ZkPromise((resolve, reject) => (succeeds ? resolve(10) : reject(10)));
76+
const promise = (succeeds) => new ZkPromise((resolve, reject) => (succeeds ? resolve(10) : reject(10)));
7777

7878
promise(true).addBoth(callback)
7979
.then((actual) => {
@@ -93,12 +93,12 @@ test('ZkPromise addBoth', (t) => {
9393
test('ZkPromise addCallbacks', (t) => {
9494
t.plan(9);
9595

96-
const callback = sinon.stub().callsFake(value => value * 2);
96+
const callback = sinon.stub().callsFake((value) => value * 2);
9797
const errback = sinon.stub().callsFake(() => {
9898
throw new Error('errback!');
9999
});
100100
// eslint-disable-next-line max-len
101-
const promise = succeeds => new ZkPromise((resolve, reject) => (succeeds ? resolve(10) : reject(10)));
101+
const promise = (succeeds) => new ZkPromise((resolve, reject) => (succeeds ? resolve(10) : reject(10)));
102102

103103
promise(true).addCallbacks(callback, errback)
104104
.then((actual) => {

tests/unit/zookeeper/nativeobjecttest.js

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ const test = require('tape');
22
const NativeZk = require('../../../build/zookeeper.node').ZooKeeper;
33
const ZooKeeper = require('../../../lib/zookeeper');
44

5-
65
test('ZooKeeper instance creates an instance of the native object', (t) => {
76
t.plan(1);
87

0 commit comments

Comments
 (0)