ESLint: lib

Author: jbienkowski311

.eslintignore

@@ -1,3 +1,2 @@
-/lib/*.js
 /tests_integration/*.js
 /deps/**/*.js

.eslintrc.json

@@ -9,6 +9,8 @@
         "airbnb-base"
     ],
     "rules": {
-        "indent": ["error", 4]
+        "indent": ["error", 4],
+        "no-console": ["error", { "allow": ["info", "warn", "error"] }],
+        "no-multi-assign": 0
     }
 }

lib/index.js

@@ -1,3 +1,4 @@
 module.exports = require('./zookeeper');
-module.exports.ZooKeeper = module.exports;  // for backwards compatibility
+
+module.exports.ZooKeeper = module.exports; // for backwards compatibility
 module.exports.Promise = require('./zk_promise');

lib/zk_promise.js

@@ -1,89 +1,89 @@
-const ZooKeeper = require("./zookeeper");
+// needed to not break the interface
+/* eslint-disable camelcase */
+const ZooKeeper = require('./zookeeper');
 
 class ZooKeeperPromise extends ZooKeeper {
-  on_connected() {
-    return new Promise((resolve) => {
-      this.once('connect', () => {
-        return resolve(this);
-      });
-    })
-  }
-
-  create() {
-    return this._promisify(super.a_create, arguments);
-  }
-
-  exists() {
-    return this._promisify(super.a_exists, arguments);
-  }
-
-  w_exists() {
-    return this._promisify(super.aw_exists, arguments);
-  }
-
-  get() {
-    return this._promisify(super.a_get, arguments);
-  }
-
-  w_get() {
-    return this._promisify(super.aw_get, arguments);
-  }
-
-  get_children() {
-    return this._promisify(super.a_get_children, arguments);
-  }
-
-  w_get_children() {
-    return this._promisify(super.aw_get_children, arguments);
-  }
-
-  get_children2() {
-    return this._promisify(super.a_get_children2, arguments);
-  }
-
-  w_get_children2() {
-    return this._promisify(super.aw_get_children2, arguments);
-  }
-
-  set() {
-    return this._promisify(super.a_set, arguments);
-  }
-
-  delete_() {
-    return this._promisify(super.delete_, arguments);
-  }
-
-  get_acl() {
-    return this._promisify(super.a_get_acl, arguments);
-  }
-
-  set_acl() {
-    return this._promisify(super.a_set_acl, arguments);
-  }
-
-  sync() {
-    return this._promisify(super.a_sync, arguments);
-  }
-
-  _promisify(fn, args) {
-    return new Promise((resolve, reject) => {
-      const callback = (rc, error, result) => {
-        if (rc) {
-          reject(rc);
-        } else {
-          if (args.length > 3) {
-            // if there are multiple success values, we return an array
-            Array.prototype.shift.call(args, 1);
-            Array.prototype.shift.call(args, 1);
-            resolve(args);
-          } else {
-            resolve(result);
-          }
-        }
-      };
-      fn.apply(this, [...args, callback])
-    });
-  }
+    on_connected() {
+        return new Promise((resolve) => {
+            this.once('connect', () => resolve(this));
+        });
+    }
+
+    create(...args) {
+        return this.promisify(super.a_create, args);
+    }
+
+    exists(...args) {
+        return this.promisify(super.a_exists, args);
+    }
+
+    w_exists(...args) {
+        return this.promisify(super.aw_exists, args);
+    }
+
+    get(...args) {
+        return this.promisify(super.a_get, args);
+    }
+
+    w_get(...args) {
+        return this.promisify(super.aw_get, args);
+    }
+
+    get_children(...args) {
+        return this.promisify(super.a_get_children, args);
+    }
+
+    w_get_children(...args) {
+        return this.promisify(super.aw_get_children, args);
+    }
+
+    get_children2(...args) {
+        return this.promisify(super.a_get_children2, args);
+    }
+
+    w_get_children2(...args) {
+        return this.promisify(super.aw_get_children2, args);
+    }
+
+    set(...args) {
+        return this.promisify(super.a_set, args);
+    }
+
+    // eslint-disable-next-line no-underscore-dangle
+    delete_(...args) {
+        // eslint-disable-next-line no-underscore-dangle
+        return this.promisify(super.delete_, args);
+    }
+
+    get_acl(...args) {
+        return this.promisify(super.a_get_acl, args);
+    }
+
+    set_acl(...args) {
+        return this.promisify(super.a_set_acl, args);
+    }
+
+    sync(...args) {
+        return this.promisify(super.a_sync, args);
+    }
+
+    promisify(fn, args) {
+        return new Promise((resolve, reject) => {
+            const callback = (rc, error, result) => {
+                if (rc) {
+                    reject(rc);
+                } else if (args.length > 3) {
+                    // if there are multiple success values, we return an array
+                    Array.prototype.shift.call(args, 1);
+                    Array.prototype.shift.call(args, 1);
+                    resolve(args);
+                } else {
+                    resolve(result);
+                }
+            };
+            fn.bind(this)(...args, callback);
+        });
+    }
 }
 
 exports = module.exports = ZooKeeperPromise;