-
Notifications
You must be signed in to change notification settings - Fork 388
feat(aggregation-mode): turn program IDs into a mapping #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JuArce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explorer is not detecting the proving system correctly. It is missing to update
@verifyRisc0_solidity_signature "0x54687ccf"
@verifySp1_solidity_signature "0xf6e04ac4"
in explorer/lib/explorer/contract_managers/aligned_proof_aggregation_service.ex
Warning
This PR requires to update config files in the servers
MarcosNicolau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SP1 is working but Risc0 is failing with InvalidProgramId
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
maximopalopoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MarcosNicolau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, it looks much readable. I am not approving it because verifyProofInclusion not being updated on the sdk (see comment above). L2 example is working correctly.
…ied instead of verify_proof_inclusion
Solved it in d5b88f6. |
Description
This PR turns the fixed program IDs for Risc0 and SP1 to be part of a map (program ID -> proving system ID), to make the system more scalable (because it's easier to add new program IDs) and retrocompatible (because this program ID - proving system is not unique anymore, and when we update the program ID now we can also handle the previous programs).
How to test
You can also follow the steps in the l2 example README to test this example.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging