Skip to content

The yarn.lock file should be placed into node_modules #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yueim opened this issue Nov 3, 2016 · 4 comments
Closed

The yarn.lock file should be placed into node_modules #1633

yueim opened this issue Nov 3, 2016 · 4 comments

Comments

@yueim
Copy link

yueim commented Nov 3, 2016

The yarn.lock file should be placed into node_modules.
Or SourceTree or WebStorm will prompt to add it to cvs.
And I metioned a .yarn-integrity file existed in node_modules, and place the yarn.lock into it should be also OK?

@maybeec
Copy link

maybeec commented Nov 3, 2016

Why not committing yarn.lock file? Basically, this will assure to have a deterministic and reproducable build. I am aware of the bad thing, that yarn.lock also stores URLs, which I would like to see parameterized over any env variable.
However, this is the only way to be totally sure, that the build will run on any machine with the same result.

@ljharb
Copy link

ljharb commented Nov 3, 2016

@cnyyk node_modules is typically gitignored. Project config files, like a lock file, are typically at the root of a repo. yarn.lock should be committed, that's the whole point.

@sebmck
Copy link
Contributor

sebmck commented Nov 3, 2016

You're supposed to commit yarn.lock. See #1067 for more discussion on this.

@sebmck sebmck closed this as completed Nov 3, 2016
@yueim
Copy link
Author

yueim commented Nov 27, 2016

Got. Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants